Skip to content

Tip admonition block style is not applied correctly in v5 #323

@tthvo

Description

@tthvo

Description

When I use the following syntax for an admonition block with TIP variant.

[This is the tip contents]{{admonition tip}}

The block is displayed but its style is incorrect. I expect it to have "custom" variant style as in this doc: https://www.patternfly.org/components/alert#alert-variants.

What I expect to see What I saw instead
image image

Environment

Using v5.3.0 with Patternfly 5.

"@patternfly/quickstarts": "^5.3.0",
"@patternfly/react-catalog-view-extension": "^5.0.0",
"@patternfly/react-charts": "^7.3.0",
"@patternfly/react-core": "^5.3.4",
"@patternfly/react-icons": "^5.3.2",
"@patternfly/react-styles": "^5.3.1",
"@patternfly/react-table": "^5.3.4",
"@patternfly/react-topology": "^5.2.0",

Others

I think a quick fix would be to set the variant of the TIP admonition to custom or simply unset it. See below:

[AdmonitionType.TIP]: { variant: 'default', customIcon: <LightbulbIcon /> },

Reference: https://www.patternfly.org/components/alert#alert

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1 ⭐bugSomething isn't working

    Type

    No type

    Projects

    Status

    Backlog

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions