Skip to content

Commit 2cf37ca

Browse files
fix(tools)!: remove cem config (#2912)
* fix(tools)!: remove cem config * chore: fix docs ci * chore: regen package lock * chore: optdeps * chore: package lock * chore: npm * chore: update deps * fix(core): add ariaRelevant to InternalsController * chore: add optdeps * chore: update deps * chore: deps * chore: update runners node version * chore: add eslint deps * fix: analyze step * docs: fix build * chore: playwright * docs: remove fw tests from readme * chore: update playwright docker image version * chore: update deps, add win32 optional, nodemon for analyze watch * chore: correct missing win32 optional in package-lock * chore: correct unsupported engine error on npm install * chore: try including optional flag for windows test * chore: add verbose flag for debuging npm ci on windows * chore: try explict install of the win32 dependency * chore: add cem config * chore: update dependencies * chore: update cem config and tasks * chore: cem config * fix(elements): export all necessary files * chore: update cem * style: lint pf-tabs.ts * style: lint elements/package.json * chore: faster analyze script * chore: update deps * chore: regen package lock * chore: ci * chore: playwright in ci --------- Co-authored-by: Steven Spriggs <[email protected]>
1 parent 6f49a79 commit 2cf37ca

38 files changed

+5610
-6095
lines changed

.changeset/green-aliens-begin.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@patternfly/pfe-core": patch
3+
---
4+
5+
`InternalsController`: add `ariaRelevant` property
6+

.changeset/solid-rice-arrive.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@patternfly/pfe-tools": major
3+
---
4+
5+
Removes the (previously deprecated) `@custom-elements-manifest/analyzer` config. Instead, use [`@pwrs/cem`](https://bennypowers.dev/cem). See PR [#2912](https://github.com/patternfly/patternfly-elements/pull/2912/files) for an example of how to migrate an npm monorepo.

.github/workflows/bundle.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ jobs:
2525
- uses: actions/checkout@v4
2626
- uses: actions/setup-node@v4
2727
with:
28-
node-version: '20'
28+
node-version-file: '.nvmrc'
2929
cache: npm
3030

3131
- name: Bundle

.github/workflows/commitlint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ jobs:
3131
fetch-depth: 0
3232
- uses: actions/setup-node@v4
3333
with:
34-
node-version: 20
34+
node-version-file: '.nvmrc'
3535
cache: npm
3636
- run: npm ci --prefer-offline
3737
- run: npm i @commitlint/load

.github/workflows/preview.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
uses: actions/checkout@v4
1414
- uses: actions/setup-node@v4
1515
with:
16-
node-version: '20'
16+
node-version-file: '.nvmrc'
1717
cache: npm
1818

1919
- name: Verify JSPM URL
@@ -23,11 +23,10 @@ jobs:
2323
run: curl https://cachefly.cachefly.net/CacheFlyDebug
2424

2525
# Set up GitHub Actions caching for Wireit.
26-
- uses: google/wireit@setup-github-actions-caching/v2
26+
- uses: google/wireit@setup-github-actions-caching/v2
2727

2828
- run: npm ci --prefer-offline
2929
- run: npm run docs
30-
- run: cat _site/components/icon/demo/custom-icon-sets/index.html
3130

3231
- name: Publish to Netlify
3332
env:

.github/workflows/release.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,8 @@ jobs:
1414
- uses: actions/checkout@v4
1515
- uses: actions/setup-node@v4
1616
with:
17-
node-version: '20'
17+
node-version-file: '.nvmrc'
1818
cache: npm
19-
2019
# Set up GitHub Actions caching for Wireit.
2120
- uses: google/wireit@setup-github-actions-caching/v2
2221

.github/workflows/tests.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ jobs:
9898
name: SSR Tests (Playwright)
9999
runs-on: ubuntu-latest
100100
container:
101-
image: mcr.microsoft.com/playwright:v1.46.1-jammy
101+
image: mcr.microsoft.com/playwright:v1.54.1-noble
102102
steps:
103103
- uses: actions/checkout@v4
104104
- uses: actions/setup-node@v4
@@ -161,8 +161,8 @@ jobs:
161161
strategy:
162162
matrix:
163163
node:
164-
- '20'
165-
- '21'
164+
- '22'
165+
- '24'
166166
if: |
167167
github.event_name == 'workflow_dispatch'
168168
|| github.event_name == 'push'
@@ -284,7 +284,7 @@ jobs:
284284
cache: npm
285285

286286
- name: Install dependencies
287-
run: npm ci --prefer-offline
287+
run: npm ci --prefer-offline --include=optional --verbose
288288

289289
- name: Build
290290
id: build

.github/workflows/visual-regression.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,14 @@ jobs:
2929
- uses: actions/checkout@v4
3030
- uses: actions/setup-node@v4
3131
with:
32-
node-version: '20'
32+
node-version-file: '.nvmrc'
3333
cache: npm
3434

3535
# Set up GitHub Actions caching for Wireit.
3636
- uses: google/wireit@setup-github-actions-caching/v2
3737

3838
- run: npm ci --prefer-offline
39-
39+
- run: npx playwright install
4040
- name: Visual Regression Tests
4141
run: npx playwright test
4242
env:

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v22.13.0
1+
v22.16.0

README.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -71,12 +71,6 @@ npm run test:watch -- --files 'elements/pf-{select,card}/test/*.spec.ts'
7171
# Run all tests excluding react and vue tests.
7272
npm run test:watch
7373

74-
# Run all tests using a React wrapper in watch mode.
75-
npm run test:react
76-
77-
# Run all tests using a Vue wrapper in watch mode.
78-
npm run test:vue
79-
8074
# Run all tests with and without React and Vue wrappers.
8175
# This is run on pull request within CI.
8276
npm run test:ci

0 commit comments

Comments
 (0)