Skip to content

fix(MessageBar): Replace send button icon - #903

Merged
rebeccaalpert merged 2 commits into
patternfly:mainfrom
gabipodolnikova:pf-4462-replace-send-icon
Sep 15, 2026
Merged

rebeccaalpert merged 2 commits into
patternfly:mainfrom
gabipodolnikova:pf-4462-replace-send-icon

Conversation

@gabipodolnikova

Copy link
Copy Markdown
Contributor

Replace the PaperPlaneIcon used by SendButton with the RH Ui Send icon from @patternfly/react-icons.

This currently uses the prerelease dependency @patternfly/react-icons@6.6.1-prerelease.2, released after PF-4576. The dependency can be updated to the stable release without code changes once available.

Restore PatternFly's default plain icon-button interaction styles while preserving the brand color for the default state.

Fixes #880

Tests:

  • npx jest --runInBand packages/module/src/MessageBar/SendButton.test.tsx
  • npm run build -w @patternfly/chatbot
  • npx eslint packages/module/src/MessageBar/SendButton.tsx

@patternfly-build

patternfly-build commented Sep 11, 2026

Copy link
Copy Markdown

@rebeccaalpert rebeccaalpert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is 100% my fault - would you be willing to use the filled version (if it exists?): https://www.figma.com/design/MSr6kVEOuAxmPOkjg7x8PO/PatternFly-6%3A-Patterns-%26-Extensions?m=auto&node-id=5190-4959&t=kak1QKBUdZzkndwZ-1

Looking at Kayla's design, we want Rh UI Send Fill Icon instead. Everything else looks great to me. 100% my fault.

@kaylachumley kaylachumley left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks for working on this. +1 on the comment about the rh filled send icon change.

Does this pr also include other icons in the message bar being reverted back to the standard icon button styling? If so, it looks like the attach plus icon needs to be changed from subtle icon color to regular icon color and same for the other variation of attach(paper clip icon). Thanks!

Image Image

@gabipodolnikova

Copy link
Copy Markdown
Contributor Author

This is 100% my fault - would you be willing to use the filled version (if it exists?): https://www.figma.com/design/MSr6kVEOuAxmPOkjg7x8PO/PatternFly-6%3A-Patterns-%26-Extensions?m=auto&node-id=5190-4959&t=kak1QKBUdZzkndwZ-1

Looking at Kayla's design, we want Rh UI Send Fill Icon instead. Everything else looks great to me. 100% my fault.

Thanks! Good catch! Let me know if it looks how it should now. I also realised that in Figma there is Stop icon we don't use. When you click the Record button, it should switch to Stop? Another issue?

@rebeccaalpert

rebeccaalpert commented Sep 15, 2026

Copy link
Copy Markdown
Member

We have the stop button here: https://chatbot-pr-chatbot-903.surge.sh/extensions/chatbot/ui#message-bar-with-stop-button. We leave the logic up to the consumers for when it's triggered - a lot of times it's used for streaming content. If you'd to make an issue for replacing that icon, you are more than welcome to!

@kaylachumley

Copy link
Copy Markdown

This is 100% my fault - would you be willing to use the filled version (if it exists?): https://www.figma.com/design/MSr6kVEOuAxmPOkjg7x8PO/PatternFly-6%3A-Patterns-%26-Extensions?m=auto&node-id=5190-4959&t=kak1QKBUdZzkndwZ-1
Looking at Kayla's design, we want Rh UI Send Fill Icon instead. Everything else looks great to me. 100% my fault.

Thanks! Good catch! Let me know if it looks how it should now. I also realised that in Figma there is Stop icon we don't use. When you click the Record button, it should switch to Stop? Another issue?

Hi @gabipodolnikova The stop button is hidden in figma and can be turned on by the user with a boolean toggle in figma if they need it for design mocks/prototypes.

@rebeccaalpert rebeccaalpert left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kaylachumley kaylachumley left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rebeccaalpert
rebeccaalpert merged commit 6d69be5 into patternfly:main Sep 15, 2026
6 checks passed
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 6.9.0-prerelease.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SendButton - Replace icon

4 participants