exportFloorplanPdf host API can't deliver its own contract: drawingType pinned

[SomSamantray]

Problem

The re-export makes exportFloorplanPdf a public host API, but drawingType is read from a store typed Extract<ConstructionDrawingType,'floor-plan'> with no setter. resolveNodeForDrawingType then drops construction-dimension nodes for any non-floor-plan drawing, while the exported PDF filename advertises that drawing type. Pre-existing internally; newly exposed as a public contract by the re-export.

Suggested fix

Add a drawingType parameter to exportFloorplanPdf (defaulting to the current store value) and stop advertising drawing-type names in filenames for drawings the export cannot perform, or lift the store pin.

Evidence

packages/editor/src/index.tsx:362-365 -- export { exportFloorplanPdf, type FloorplanExportScope } from './lib/floorplan/floorplan-export'

Source

Branch feat/floorplan-export-routing-scope (head f2d3051) — planned PR for #619.

Metadata

Severity: P3 | Confidence: 75 | Reviewer(s): adversarial | Finding ID: index-tsx-362-drawingtype-pin

[SomSamantray]

Carried by PR: #636

[Aymericr]

Closing — the premise doesn't hold. drawingType is typed Extract<ConstructionDrawingType, 'floor-plan'>, so it's pinned to the only value it can ever have. There is no non-floor-plan drawing for the export to mis-deliver: the filename is always floor-plan_<scope>_<date>.pdf, which is correct, and resolveNodeForDrawingType always receives 'floor-plan'. The DRAWING_TYPE_OPTIONS.find(...) ?? 'Floor plan' lookup is currently a dead branch.

There is a real enhancement buried in here — exportFloorplanPdf should take a drawingType — but it only becomes meaningful once foundation, reflected-ceiling, roof and site plans are actually implemented. That's tracked with the broader construction-documentation work, not as a contract bug.