Skip to content

Commit bbeaa01

Browse files
authored
fix: cleanup the query list command (#52)
1 parent e7eca08 commit bbeaa01

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

cmd/filterList.go renamed to cmd/filterlist.go

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,15 +28,14 @@ import (
2828
var FilterList = &cobra.Command{
2929
Use: "list",
3030
Example: "pb query list ",
31-
Short: "List of saved filter for a stream",
32-
Long: "\nShow a list of saved filter for a stream ",
31+
Short: "List of saved filters",
32+
Long: "\nShow the list of saved filters for current user",
3333
PreRunE: PreRunDefaultProfile,
3434
Run: func(_ *cobra.Command, _ []string) {
3535
client := DefaultClient()
3636

3737
p := model.UIApp()
38-
_, err := p.Run()
39-
if err != nil {
38+
if _, err := p.Run(); err != nil {
4039
os.Exit(1)
4140
}
4241

@@ -46,17 +45,18 @@ var FilterList = &cobra.Command{
4645
filterToPbQuery(a.Stream(), a.StartTime(), a.EndTime())
4746
}
4847
if d.FilterID() != "" {
49-
deleteFilter(&client, d.FilterID())
48+
deleteFilter(&client, d.FilterID(), d.Title())
5049
}
5150
},
5251
}
5352

5453
// Delete a saved filter from the list of filter
55-
func deleteFilter(client *HTTPClient, filterID string) {
54+
func deleteFilter(client *HTTPClient, filterID, title string) {
55+
fmt.Printf("\nAttempting to delete '%s'", title)
5656
deleteURL := `filters/filter/` + filterID
5757
req, err := client.NewRequest("DELETE", deleteURL, nil)
5858
if err != nil {
59-
fmt.Println("Error deleting the filter")
59+
fmt.Println("Failed to delete the filter with error: ", err)
6060
}
6161

6262
resp, err := client.client.Do(req)
@@ -66,7 +66,7 @@ func deleteFilter(client *HTTPClient, filterID string) {
6666
defer resp.Body.Close()
6767

6868
if resp.StatusCode == 200 {
69-
fmt.Printf("\n\nFilter Deleted")
69+
fmt.Printf("\nFilter deleted\n\n")
7070
}
7171
}
7272

pkg/model/savedFilters.go renamed to pkg/model/savedfilters.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,8 @@ func fetchFilters(client *http.Client, profile *config.Profile) []list.Item {
254254
fmt.Println("Error unmarshalling response:", err)
255255
return nil
256256
}
257+
258+
// This returns only the SQL type filters
257259
var userFilters []list.Item
258260
for _, filter := range filters {
259261
var userFilter Item

0 commit comments

Comments
 (0)