removed support for signing as deprecated by MS, unsealed a bunch of methods in universal aspect

Author: pamidur

.devcontainer/devcontainer.json

@@ -0,0 +1,24 @@
+{
+	"name": "C# (.NET)",
+	"image": "mcr.microsoft.com/devcontainers/dotnet:1-8.0",
+	"workspaceMount": "source=${localWorkspaceFolder},target=/workspace,type=bind,Z",
+	"workspaceFolder": "/workspace",
+	"runArgs": [
+		"--userns=keep-id:uid=1000,gid=1000"
+	],
+	"updateRemoteUserUID": false,
+	"securityOpt": [
+		"label=type:container_t"
+	],
+	"containerEnv": {
+		"HOME": "/home/vscode"
+	},
+	"containerUser": "vscode",
+	"customizations": {
+		"vscode": {
+			"extensions": [
+				"ms-dotnettools.csdevkit"
+			]
+		}
+	}
+}

aspects/Universal/Attributes/BaseMethodPointsAspectAttribute.cs

@@ -6,7 +6,7 @@ namespace Aspects.Universal.Attributes
 {
     public abstract class BaseMethodPointsAspectAttribute : BaseUniversalWrapperAttribute
     {
-        protected internal sealed override T WrapSync<T>(Func<object[], T> target, object[] args, AspectEventArgs eventArgs)
+        protected internal override T WrapSync<T>(Func<object[], T> target, object[] args, AspectEventArgs eventArgs)
         {
             OnBefore(eventArgs);
 
@@ -23,7 +23,7 @@ protected internal sealed override T WrapSync<T>(Func<object[], T> target, objec
             }
         }
 
-        protected internal sealed override async Task<T> WrapAsync<T>(Func<object[], Task<T>> target, object[] args, AspectEventArgs eventArgs)
+        protected internal override async Task<T> WrapAsync<T>(Func<object[], Task<T>> target, object[] args, AspectEventArgs eventArgs)
         {
             await OnBeforeAsync(eventArgs);
 

src/AspectInjector/build/AspectInjector.targets

@@ -15,9 +15,7 @@
 
   <PropertyGroup>
     <_InjectAspectsDependsOn>
-      AspectInjector_Custom_Target;
       AspectInjector_InjectAspectsCore;
-      AspectInjector_ResignAssembly;
     </_InjectAspectsDependsOn>
   </PropertyGroup>
 
@@ -42,49 +40,5 @@
     <Touch Files="%(IntermediateAssembly.FullPath).aspectsinjected" AlwaysCreate="true" Time="%(IntermediateAssembly.ModifiedTime)"/>
   </Target>
 
-  <Target Name="AspectInjector_ResignAssembly" 
-          Condition="'$(SignAssembly)' == 'true' AND '$(DelaySign)' != 'true'" 
-          DependsOnTargets="GetSnToolForUnix;GetSnToolForWindows"
-          Inputs="@(IntermediateAssembly->'%(FullPath)')" 
-          Outputs="%(IntermediateAssembly.FullPath).aspectssigned"
-    >
-    <PropertyGroup>
-      <_SignCommand Condition="'$(KeyContainerName)' != ''">&quot;$(SnTool)&quot; -Rc &quot;$(ProjectDir)$(IntermediateOutputPath)$(TargetFileName)&quot; $(KeyContainerName)</_SignCommand>
-      <_SignCommand Condition="'$(KeyContainerName)' == '' AND '$(KeyOriginatorFile)' != ''">&quot;$(SnTool)&quot; -R &quot;$(ProjectDir)$(IntermediateOutputPath)$(TargetFileName)&quot; $(KeyOriginatorFile)</_SignCommand>
-    </PropertyGroup>
-    <Exec Command="$(_SignCommand)" Condition="'$(_SignCommand)' != ''" EchoOff="true" IgnoreExitCode="true">
-      <Output TaskParameter="ExitCode" PropertyName="_SignExitCode" />
-    </Exec>
-    <Error Text="Aspect Injector cannot re-sing assembly. Try rebuid solution." Condition="'$(_SignExitCode)' != '0'" Code="AI_ERR0" File="AspectInjector"/>
-    <Touch Files="%(IntermediateAssembly.FullPath).aspectsinjected" AlwaysCreate="true" Time="%(IntermediateAssembly.ModifiedTime)"/>
-    <Touch Files="%(IntermediateAssembly.FullPath).aspectssigned" AlwaysCreate="true" Time="%(IntermediateAssembly.ModifiedTime)"/>
-  </Target>
-
-  <Target Name="GetSnToolForUnix" Condition=" '$(OS)' == 'Unix' ">
-    <PropertyGroup>
-      <SnTool>sn</SnTool>
-    </PropertyGroup>
-    <Message Text="SnTool found: $(SnTool)"/>
-  </Target>
-
-  <Target Name="GetSnToolForWindows" Condition=" '$(OS)' != 'Unix' ">
-    <GetFrameworkSdkPath>
-      <Output TaskParameter="Path" PropertyName="WindowsSdkPath" />
-    </GetFrameworkSdkPath>
-    <ItemGroup>
-      <SnTools Include="$(WindowsSdkPath)**\sn.exe" />
-    </ItemGroup>
-    <PropertyGroup>
-      <SnToolsRaw>@(SnTools)</SnToolsRaw>
-    </PropertyGroup>
-    <PropertyGroup>
-      <SnTool>$(SnToolsRaw.Split(';')[0])</SnTool>
-    </PropertyGroup>
-    <Message Text="SnTool found: $(SnTool)"/>
-  </Target>
-
-  <Target Name="AspectInjector_Custom_Target">
-  </Target>
-
 </Project>