Skip to content

Commit 71f054c

Browse files
authored
Fix broken links (cotes2020#2077)
Added GitHub action to check for broken links in repo before commit, ignoring files with liquid tags since these were not yet processed and also README since some sites created from this template doesn't have valid urls anymore. Fixed some broken links in repo. --------- Signed-off-by: George Araújo <[email protected]>
1 parent 0a737aa commit 71f054c

File tree

14 files changed

+28
-21
lines changed

14 files changed

+28
-21
lines changed

.github/workflows/broken-links.yml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
name: Check for broken links
2+
3+
on:
4+
push:
5+
pull_request:
6+
7+
jobs:
8+
link-checker:
9+
runs-on: ubuntu-latest
10+
steps:
11+
- uses: actions/checkout@v3
12+
13+
- name: Link Checker 🔗
14+
uses: lycheeverse/[email protected]
15+
with:
16+
fail: true
17+
# removed md files that include liquid tags
18+
args: --exclude-path README.md --exclude-path _pages/404.md --exclude-path _pages/blog.md --exclude-path _posts/2018-12-22-distill.md --verbose --no-progress './**/*.md' './**/*.html'

CUSTOMIZE.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ The project is structured as follows, focusing on the main components that you w
88

99
```txt
1010
.
11-
├── 📄 404.html: 404 page (page not found)
1211
├── 📂 assets/: contains the assets that are displayed in the website
1312
│   └── 📂 json/
1413
│   └── 📄 resume.json: CV in JSON format (https://jsonresume.org/)
@@ -19,10 +18,11 @@ The project is structured as follows, focusing on the main components that you w
1918
│   ├── 📄 cv.yml: CV in YAML format, used when assets/json/resume.json is not found
2019
│   └── 📄 repositories.yml: users and repositories info in YAML format
2120
├── 📂 _includes/: contains code parts that are included in the main HTML file
21+
│   └── 📄 news.liquid: defines the news section layout in the about page
2222
├── 📂 _layouts/: contains the layouts to choose from in the frontmatter of the Markdown files
2323
├── 📂 _news/: the news that will appear in the news section in the about page
24-
├── 📄 news.html: defines the news section layout in the about page
25-
── 📂 _pages/: contains the pages of the website that are shown in the header
24+
├── 📂 _pages/: contains the pages of the website
25+
| └── 📄 404.md: 404 page (page not found)
2626
├── 📂 _posts/: contains the blog posts
2727
├── 📂 _projects/: contains the projects
2828
└── 📂 _sass/: contains the SASS files that define the style of the website
@@ -136,7 +136,7 @@ There are several custom bibtex keywords that you can use to affect how the entr
136136
- `supp`: Adds a "Supp" button to a specified file (if a full link is not specified, the file will be assumed to be placed in the /assets/pdf/ directory)
137137
- `website`: Adds a "Website" button redirecting to the specified link
138138

139-
You can implement your own buttons by editing the [\_layouts/bib.html](_layouts/bib.html) file.
139+
You can implement your own buttons by editing the [\_layouts/bib.liquid](_layouts/bib.liquid) file.
140140

141141
## Changing theme color
142142

INSTALL.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ $ docker compose pull
3434
$ docker compose up
3535
```
3636

37-
Note that when you run it for the first time, it will download a docker image of size 400MB or so. To see the template running, open your browser and go to [http://localhost:8888](http://localhost:8888). You should see a copy of the theme's demo website.
37+
Note that when you run it for the first time, it will download a docker image of size 400MB or so. To see the template running, open your browser and go to `http://localhost:8888`. You should see a copy of the theme's demo website.
3838

3939
Now, feel free to customize the theme however you like (don't forget to change the name!). After you are done, you can use the same command (`docker compose up`) to render the webpage with all you changes. Also, make sure to commit your final changes.
4040

@@ -70,7 +70,7 @@ $ pip install jupyter
7070
$ bundle exec jekyll serve --lsi
7171
```
7272

73-
To see the template running, open your browser and go to [http://localhost:4000](http://localhost:4000). You should see a copy of the theme's [demo website](https://alshedivat.github.io/al-folio/). Now, feel free to customize the theme however you like. After you are done, remember to **commit** your final changes.
73+
To see the template running, open your browser and go to `http://localhost:4000`. You should see a copy of the theme's [demo website](https://alshedivat.github.io/al-folio/). Now, feel free to customize the theme however you like. After you are done, remember to **commit** your final changes.
7474

7575
## Deployment
7676

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ Photo formatting is made simple using [Bootstrap's grid system](https://getboots
296296

297297
<p align="center">
298298
<a href="https://alshedivat.github.io/al-folio/projects/1_project/">
299-
<img src="https://raw.githubusercontent.com/alshedivat/al-folio/master/assets/img/photos-screenshot.png" width="75%">
299+
<img src="assets/img/readme_preview/photos-screenshot.png" width="75%">
300300
</a>
301301
</p>
302302

@@ -318,7 +318,7 @@ You may also use the following codes for displaying this in any other pages.
318318
<!-- code for GitHub users -->
319319
{% if site.data.repositories.github_users %}
320320
<div class="repositories d-flex flex-wrap flex-md-row flex-column justify-content-between align-items-center">
321-
{% for user in site.data.repositories.github_users %} {% include repository/repo_user.html username=user %} {% endfor %}
321+
{% for user in site.data.repositories.github_users %} {% include repository/repo_user.liquid username=user %} {% endfor %}
322322
</div>
323323
{% endif %}
324324

@@ -327,14 +327,14 @@ You may also use the following codes for displaying this in any other pages.
327327
<h4>{{ user }}</h4>
328328
{% endif %}
329329
<div class="repositories d-flex flex-wrap flex-md-row flex-column justify-content-between align-items-center">
330-
{% include repository/repo_trophies.html username=user %}
330+
{% include repository/repo_trophies.liquid username=user %}
331331
</div>
332332
{% endfor %} {% endif %}
333333

334334
<!-- code for GitHub repositories -->
335335
{% if site.data.repositories.github_repos %}
336336
<div class="repositories d-flex flex-wrap flex-md-row flex-column justify-content-between align-items-center">
337-
{% for repo in site.data.repositories.github_repos %} {% include repository/repo.html repository=repo %} {% endfor %}
337+
{% for repo in site.data.repositories.github_repos %} {% include repository/repo.liquid repository=repo %} {% endfor %}
338338
</div>
339339
{% endif %}
340340
```

_config.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,6 @@ scholar:
291291
join_strings: true
292292

293293
details_dir: bibliography
294-
details_layout: bibtex.html
295294
details_link: Details
296295

297296
query: "@*"

_includes/projects.liquid

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
<!-- _includes/projects.html -->
21
<div class="grid-sizer"></div>
32
<div class="grid-item">
43
<a href="{% if project.redirect %}{{ project.redirect }}{% else %}{{ project.url | relative_url }}{% endif %}">

_layouts/about.liquid

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
---
22
layout: default
33
---
4-
<!-- about.html -->
54
<div class="post">
65
<header class="post-header">
76
<h1 class="post-title">

_layouts/bib.liquid

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
---
22
---
3-
<!-- _layouts/bib.html -->
43
<div class="row">
54
{% if site.enable_publication_thumbnails %}
65
<div class="col-sm-2 {% if entry.preview %}preview{% else %}abbr{% endif %}">

_layouts/cv.liquid

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
---
22
layout: default
33
---
4-
<!-- _layouts/cv.html -->
54
{% unless site.data.resume %}
65
<div class="post">
76
<header class="post-header">

_layouts/distill.liquid

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
<!doctype html>
2-
<!-- _layouts/distill.html -->
32
<html>
43
<head>
54
{% include head.liquid %}

0 commit comments

Comments
 (0)