-
Notifications
You must be signed in to change notification settings - Fork 128
Closed
Description
This commit of the name-suggestion-index causes the tests of TagFix_Brand to fail. (Note there were more commits of a similar type)
Reason: in this plugin (and 2 others) we check the country versus the country code, e.g. FR. However, it's now changed to fr-pac.geojson (and several others, like fr-20r.geojson)
Affected plugins:
TagFix_Brand(NSI for data)Name_UpperCase(NSI for whitelists)Name_Script(NSI for whitelists)
Proposed fix:
- make all locationSet-parsing-code uniform and support subdivided countries -> Make NSI country filter uniform #2386
- where possible, convert the geojson file names to country codes (e.g.
BR-AC.geojsoncan be converted by just dropping.geojsonfrom the file name (and homogenize case for some countries))
Countries where this will work: AT, AU, BR, CA, CH, (part of) DE, ES, IT, MX, (part of) PH, (part of) US -> also Make NSI country filter uniform #2386 - where not possible (e.g. France, which Osmose divides into departments, but NSI into arrondissements) use a map. Unless there's a very efficient way to check if an Osmose-division is fully within an NSI-division (while considering tiny border differences). (Or maybe make modifications to osmose_config in case it's divided in smaller divisions in NSI). Or maybe use the library they use with the
isInfunction (but then we should also fetch the geojson files)
Countries/regions: (part of) DE, DK, FR, GB, IE, JP, NZ, (part of) PH, ru-spe, (part of) US, some special cases (e.g. crimea)