vmtest: do one retry on ssh connect failure #1153
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
requested review from
achilleas-k,
bcl and
croissanne
and removed request for
a team
achilleas-k
requested changes
Nov 18, 2025
vmtest/vm.py
Outdated
| time.sleep(0.5) | ||
| self._connect(user, password, pkey) | ||
|
|
||
| def _connect(self, user, password, pkey): |
Member
There was a problem hiding this comment.
Needs client as an arg. Or maybe add _client to the VM class?
We see some errors when conneting to the vm. Its odd as we have a helper wait_ssh_ready() that opens the ports and check for the OpenSSH banner string. Until this is fully understood do a single retry to make the vmtest more robust.
Collaborator
Author
|
This is actually not sufficient, the retry needs to happen on open_session() |
Collaborator
Author
|
Closing in favor of #1156 - if moving to ssh is not enough we will need to add something like a retry of "self.run(true") to make this more robust but it should be passed on ssh instead of paramiko. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We see some errors when conneting to the vm. Its odd as we have a helper wait_ssh_ready() that opens the ports and check for the OpenSSH banner string. Until this is fully understood do a single retry to make the vmtest more robust.
See e.g. https://gitlab.com/redhat/services/products/image-builder/ci/images/-/jobs/12115586516