Skip to content

HMR not working properly, webpack header not identified correctly #1058

@masmrlar

Description

@masmrlar

The HMR feature is not working properly as the check if the webpack server is running does not identify the server correctly.

Issue is

array_search('Express', $response->getHeader('x-powered-by'));

where array_search is used to check if Express is set on the header value - which returns 0 and results to false in this implementation of the check.

Activity

anyt

anyt commented on Mar 29, 2021

@anyt
Contributor

Hi Thomas,
It's a known issue, and there are many others with HMR since JS build was moved to webpack. For now, we can recommend using the watch option. I know it's not the same, but this is the closest experience we can offer.
Thank you for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @masmrlar@anyt

        Issue actions

          HMR not working properly, webpack header not identified correctly · Issue #1058 · oroinc/platform