do we want to keep sourcery.ai in its current form?

[deronnax]

It adds significant noise to PR, and I don't see its feedbacks on PRs being read/leverage that much lately, compared to when it was introduced few months ago.
Also, I have the feeling its noise might numb reviewers, and allow AI-generated/well-crafted malicious code slip-in. I don't have much to elaborate on this, but from my experience using AI for coding and reviews (and I do significantly use it daily for this), it is good to catch somewhat obviously malevolent code, but is easily tricked when a malevolent code is designed to look legit. And I fear its current auto-mode might one day trick us into approving a PR we would not have approved otherwise.

Has a less verbose mode being considered? Or even a lighter, less verbose alternative?
What about switching it to a manual mode: having a sourcery.ai review when asked?

[radoering]

Good question. There are some really good review comments among the noise. Personally, I can filter it but I understand that the signal-to-noise ratio is not that good and a new contributor may either think they have to put each suggestion into practice or just ignore everything.

I would be fine with on-demand reviews. I do not know if that can be configured. @abn set up sourcery.

[abn]

👋 Over all I think there is still value in it. The objective of the integration is not necessarily to catch malevolent code, it has always been to filter out the most obvious types of issues - helping to reduce the expectation on immediate maintainer attention a bit. But I would like to hear from the more active folks from @python-poetry/core on this as I have been a bit inactive recently.

Fwiw, I can also see the point that it can be a bit noisy, however I am of the same view as @radoering in that personally I am okay with it.

I reckon maybe the first step would be to try tune sourcery a bit more. They do allow for a few options to tweak things. We can start by adding some review rules. And if that does not work either after a few iterations, then we can disable sourcery reviews altogether and use it only for the summary/review guides.

@deronnax it would also be great if you have a few examples in mind that led you to start the discussion in the first place. Might help formulate any rules we want to add.

PS: All maintainers should have access to the config at https://app.sourcery.ai/