Skip to content

Commit ebee4e6

Browse files
committed
jt: set @mx_env and @ruby_name early so they are always set
1 parent 1cf7b9f commit ebee4e6

File tree

1 file changed

+16
-17
lines changed

1 file changed

+16
-17
lines changed

tool/jt.rb

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ def get_truffle_version(from: :suite)
190190
end
191191

192192
def ee?
193-
(@mx_env || @ruby_name || '').include?('ee')
193+
@mx_env.include?('ee') || @ruby_name.include?('ee')
194194
end
195195

196196
def ee_jdk?
@@ -259,14 +259,12 @@ def env_path(env)
259259
end
260260

261261
def used_ruby_is_mx_env_name?
262-
ruby_launcher # to set @ruby_name
263262
File.file?(env_path(@ruby_name))
264263
end
265264

266265
def ruby_launcher
267266
return @ruby_launcher if defined? @ruby_launcher
268267

269-
@ruby_name ||= ENV['RUBY_BIN'] || ENV['JT_ENV'] || 'jvm'
270268
ruby_launcher = if @ruby_name == 'ruby'
271269
ENV['RBENV_ROOT'] ? `rbenv which ruby`.chomp : which('ruby')
272270
elsif @ruby_name.start_with?('/')
@@ -2615,21 +2613,20 @@ def sforceimports
26152613
FileUtils.touch(build_information_path)
26162614
end
26172615

2618-
env = if (i = options.index('--env') || options.index('-e'))
2619-
options.delete_at i
2620-
options.delete_at i
2621-
else
2622-
ENV['JT_ENV'] || 'jvm'
2623-
end
2624-
@mx_env = env
2625-
raise 'Cannot use both --use and --env' if defined?(@ruby_name)
2616+
# Override @mx_env if --env is passed
2617+
if (i = options.index('--env') || options.index('-e'))
2618+
options.delete_at i
2619+
@mx_env = options.delete_at i
2620+
end
2621+
env = @mx_env
26262622

2627-
@ruby_name = if (i = options.index('--name') || options.index('-n'))
2628-
options.delete_at i
2629-
options.delete_at i
2630-
else
2631-
env
2632-
end
2623+
# Override @ruby_name from --name or --env
2624+
if (i = options.index('--name') || options.index('-n'))
2625+
options.delete_at i
2626+
@ruby_name = options.delete_at i
2627+
else
2628+
@ruby_name = env
2629+
end
26332630

26342631
name = "truffleruby-#{@ruby_name}"
26352632
mx_base_args = ['--env', env]
@@ -3309,6 +3306,8 @@ def process_pre_args(args)
33093306
@silent = false
33103307
@verbose = false
33113308
@jdk_version = ENV['JT_JDK'] || DEFAULT_JDK_VERSION
3309+
@ruby_name = ENV['RUBY_BIN'] || ENV['JT_ENV'] || 'jvm'
3310+
@mx_env = ENV['JT_ENV'] || 'jvm'
33123311

33133312
until args.empty?
33143313
arg = args.shift

0 commit comments

Comments
 (0)