-
Notifications
You must be signed in to change notification settings - Fork 19
Update occurrences oracle-samples -> oracle #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
endurthiabhilash
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| argocd.argoproj.io/sync-wave: "3" | ||
| spec: | ||
| package: ghcr.io/oracle-samples/provider-oci-certificatesmanagement:v0.0.1-alpha.1-amd64 | ||
| package: ghcr.io/oracle/provider-oci-certificatesmanagement:v0.0.1-alpha.1-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new image doesn't exist yet.
| argocd.argoproj.io/sync-wave: "3" | ||
| spec: | ||
| package: ghcr.io/oracle-samples/provider-oci-containerengine:v0.0.1-alpha.1-amd64 | ||
| package: ghcr.io/oracle/provider-oci-containerengine:v0.0.1-alpha.1-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new image doesn't exist yet.
| argocd.argoproj.io/sync-wave: "1" | ||
| spec: | ||
| package: ghcr.io/oracle-samples/provider-family-oci:v0.0.1-alpha.1-amd64 | ||
| package: ghcr.io/oracle/provider-family-oci:v0.0.1-alpha.1-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new image doesn't exist yet.
| argocd.argoproj.io/sync-wave: "3" | ||
| spec: | ||
| package: ghcr.io/oracle-samples/provider-oci-identity:v0.0.1-alpha.1-amd64 | ||
| package: ghcr.io/oracle/provider-oci-identity:v0.0.1-alpha.1-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new image doesn't exist yet. I won't call this out anymore but there are many more places like this we should address.
docs/quickstart.md
Outdated
| > Adhere to the following naming format for providers as: `(organization)-(provider-name)`, eg: oracle-samples-provider-family-oci. | ||
| > When pulling the image from a registry, crossplane formats the name as `registry.io/organization/provider-name:tags`, eg: ghcr.io/oracle-samples/provider-family-oci:v0.0.1-alpha.1-amd64. | ||
| > Adhere to the following naming format for family provider as: `(organization)-(provider-name)`, eg: oracle-provider-family-oci. | ||
| > When pulling the image from a registry, crossplane refers to the name as `registry.io/organization/provider-name:tags`, eg: ghcr.io/oracle/provider-family-oci:v0.0.1-alpha.1-amd64. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This new image doesn't exist yet.
9a14790
f3bd538 to
9a14790
Compare
Description of your changes
Updated every occurrence of
oracle-samplestooracle. Fixed links.I have: