From e86c8702125f9861795e3f0a6ef28f66827bad94 Mon Sep 17 00:00:00 2001 From: Agrim Khanna Date: Wed, 30 Jul 2025 16:09:22 +0530 Subject: [PATCH 1/2] added support for custom model name for single MD --- ads/aqua/model/model.py | 4 ++++ ads/aqua/modeldeployment/deployment.py | 3 ++- ads/aqua/modeldeployment/entities.py | 3 +++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/ads/aqua/model/model.py b/ads/aqua/model/model.py index 2b5d7108f..d5dffb978 100644 --- a/ads/aqua/model/model.py +++ b/ads/aqua/model/model.py @@ -147,6 +147,7 @@ class AquaModelApp(AquaApp): def create( self, model_id: Union[str, AquaMultiModelRef], + display_name: Optional[str] = None, project_id: Optional[str] = None, compartment_id: Optional[str] = None, freeform_tags: Optional[Dict] = None, @@ -204,6 +205,9 @@ def create( **(defined_tags or {}), } + if display_name: + service_model.display_name = display_name + custom_model = ( DataScienceModel() .with_compartment_id(target_compartment) diff --git a/ads/aqua/modeldeployment/deployment.py b/ads/aqua/modeldeployment/deployment.py index 3e93f38ee..c11425f17 100644 --- a/ads/aqua/modeldeployment/deployment.py +++ b/ads/aqua/modeldeployment/deployment.py @@ -214,6 +214,7 @@ def create( ) aqua_model = model_app.create( model_id=create_deployment_details.model_id, + display_name=create_deployment_details.model_name, compartment_id=compartment_id, project_id=project_id, freeform_tags=freeform_tags, @@ -446,6 +447,7 @@ def _create( cmd_var_string = aqua_model.custom_metadata_list.get( AQUA_DEPLOYMENT_CONTAINER_CMD_VAR_METADATA_NAME ).value + default_cmd_var = shlex.split(cmd_var_string) if default_cmd_var: cmd_var = validate_cmd_var(default_cmd_var, cmd_var) @@ -538,7 +540,6 @@ def _create( ) deployment_params = get_combined_params(config_params, user_params) - params = f"{params} {deployment_params}".strip() if params: env_var.update({"PARAMS": params}) diff --git a/ads/aqua/modeldeployment/entities.py b/ads/aqua/modeldeployment/entities.py index ebce26dc8..5b31f1611 100644 --- a/ads/aqua/modeldeployment/entities.py +++ b/ads/aqua/modeldeployment/entities.py @@ -233,6 +233,9 @@ class CreateModelDeploymentDetails(BaseModel): None, description="The description of the deployment." ) model_id: Optional[str] = Field(None, description="The model OCID to deploy.") + model_name: Optional[str] = Field( + None, description="The model name specified by user to deploy." + ) models: Optional[List[AquaMultiModelRef]] = Field( None, description="List of models for multimodel deployment." ) From 2b7120de7e19f4dad3b325cbdbed5f15ec3a6021 Mon Sep 17 00:00:00 2001 From: Agrim Khanna Date: Fri, 1 Aug 2025 15:41:48 +0530 Subject: [PATCH 2/2] PR review comments --- ads/aqua/model/model.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ads/aqua/model/model.py b/ads/aqua/model/model.py index d5dffb978..c848b2103 100644 --- a/ads/aqua/model/model.py +++ b/ads/aqua/model/model.py @@ -147,11 +147,11 @@ class AquaModelApp(AquaApp): def create( self, model_id: Union[str, AquaMultiModelRef], - display_name: Optional[str] = None, project_id: Optional[str] = None, compartment_id: Optional[str] = None, freeform_tags: Optional[Dict] = None, defined_tags: Optional[Dict] = None, + display_name: Optional[str] = None, **kwargs, ) -> DataScienceModel: """ @@ -170,6 +170,8 @@ def create( Freeform tags for the model. defined_tags : Optional[Dict] Defined tags for the model. + display_name: ptional[str] + The display name of the custom model. Returns -------