Skip to content

Commit 230335e

Browse files
committed
review feedback addressed.
1 parent 9c91ca7 commit 230335e

File tree

2 files changed

+3
-12
lines changed

2 files changed

+3
-12
lines changed

internal/service/odb/network.go

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import (
1313
"github.com/hashicorp/terraform-plugin-framework-timeouts/resource/timeouts"
1414
"github.com/hashicorp/terraform-plugin-framework-timetypes/timetypes"
1515
"github.com/hashicorp/terraform-plugin-framework-validators/stringvalidator"
16-
"github.com/hashicorp/terraform-plugin-framework/attr"
1716
"github.com/hashicorp/terraform-plugin-framework/path"
1817
"github.com/hashicorp/terraform-plugin-framework/resource"
1918
"github.com/hashicorp/terraform-plugin-framework/resource/schema"
@@ -34,7 +33,6 @@ import (
3433
"github.com/hashicorp/terraform-provider-aws/names"
3534
)
3635

37-
// Function annotations are used for resource registration to the Provider. DO NOT EDIT.
3836
// @FrameworkResource("aws_odb_network", name="Network")
3937
// @Tags(identifierAttribute="arn")
4038
func newResourceNetwork(_ context.Context) (resource.ResourceWithConfigure, error) {
@@ -162,12 +160,6 @@ func (r *resourceNetwork) Schema(ctx context.Context, req resource.SchemaRequest
162160
CustomType: fwtypes.NewListNestedObjectTypeOf[odbNwkOciDnsForwardingConfigResourceModel](ctx),
163161
Computed: true,
164162
Description: "The DNS resolver endpoint in OCI for forwarding DNS queries for the ociPrivateZone domain.",
165-
ElementType: types.ObjectType{
166-
AttrTypes: map[string]attr.Type{
167-
names.AttrDomainName: types.StringType,
168-
"oci_dns_listener_ip": types.StringType,
169-
},
170-
},
171163
},
172164
"peered_cidrs": schema.SetAttribute{
173165
CustomType: fwtypes.SetOfStringType,
@@ -456,8 +448,8 @@ func (r *resourceNetwork) Update(ctx context.Context, req resource.UpdateRequest
456448
)
457449
return
458450
}
459-
state.S3Access = fwtypes.StringEnumValue(readS3AccessStatus)
460-
state.S3PolicyDocument = types.StringPointerValue(updatedOdbNwk.ManagedServices.S3Access.S3PolicyDocument)
451+
plan.S3Access = fwtypes.StringEnumValue(readS3AccessStatus)
452+
plan.S3PolicyDocument = types.StringPointerValue(updatedOdbNwk.ManagedServices.S3Access.S3PolicyDocument)
461453

462454
readZeroEtlAccessStatus, err := mapManagedServiceStatusToAccessStatus(updatedOdbNwk.ManagedServices.ZeroEtlAccess.Status)
463455
if err != nil {
@@ -467,7 +459,7 @@ func (r *resourceNetwork) Update(ctx context.Context, req resource.UpdateRequest
467459
)
468460
return
469461
}
470-
state.ZeroEtlAccess = fwtypes.StringEnumValue(readZeroEtlAccessStatus)
462+
plan.ZeroEtlAccess = fwtypes.StringEnumValue(readZeroEtlAccessStatus)
471463

472464
resp.Diagnostics.Append(flex.Flatten(ctx, updatedOdbNwk, &plan)...)
473465
resp.Diagnostics.Append(resp.State.Set(ctx, &plan)...)

internal/service/odb/network_data_source.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import (
1919
"github.com/hashicorp/terraform-provider-aws/names"
2020
)
2121

22-
// Function annotations are used for datasource registration to the Provider. DO NOT EDIT.
2322
// @FrameworkDataSource("aws_odb_network", name="Network")
2423
// @Tags(identifierAttribute="arn")
2524
func newDataSourceNetwork(context.Context) (datasource.DataSourceWithConfigure, error) {

0 commit comments

Comments
 (0)