Skip to content

Commit e8faebb

Browse files
authored
Merge pull request #407 from openzim/fix_help
Fix help and add test case to check this important feature
2 parents 9bf3ea4 + 0e69193 commit e8faebb

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

.github/workflows/Tests.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,9 @@ jobs:
5959
- name: build image
6060
run: docker build -t zimit .
6161

62+
- name: ensure help display without issue
63+
run: docker run -v $PWD/output:/output zimit zimit --help
64+
6265
- name: run crawl
6366
run: docker run -v $PWD/output:/output zimit zimit --url http://isago.rskg.org/ --name isago --zim-file isago.zim --adminEmail [email protected] --mobileDevice "Pixel 5" --statsFilename /output/stats.json --keep
6467

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1111

1212
- Upgrade to browsertrix crawler 1.3.2, warc2zim 2.1.2 and other dependencies (#406)
1313

14+
### Fixed
15+
16+
- Fix help (#393)
17+
1418
## [2.1.2] - 2024-09-09
1519

1620
### Changed

src/zimit/zimit.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ def run(raw_args):
287287
parser.add_argument(
288288
"--diskUtilization",
289289
help="Save state and exit if disk utilization exceeds this percentage value."
290-
" Default (if not set) is 90%. Set to 0 to disable disk utilization check.",
290+
" Default (if not set) is 90%%. Set to 0 to disable disk utilization check.",
291291
type=int,
292292
default=90,
293293
)

0 commit comments

Comments
 (0)