luci-app-attendedsysupgrade: firmware upgrade check popup does not stay closed

[Lanchon]

Is there an existing issue for this?

• I have searched among all existing issues (including closed issues)

Actual behaviour

in the welcome/status page, if the "Check online for firmware upgrades" modal popup is dismissed with "Close", it will pop up again seconds later when the ajax page values auto-refresh (without the page being reloaded by the user).

Expected behaviour

click "Close", the popup is dismissed, and it does not pop up again (until the page is reloaded by the user).

Steps to reproduce

1. reset router settings
2. log in.
3. hit "Close" in popup and wait.

Additional Information

this is a detail but is incredibly nagging. one might have reason to not want initialize that setting, and the nagging makes the status page effectively unusable unless you have something like uBlock Origin to zap the dialog.

the fix is simple. one way to fix it is to set a boolean variable in the "Close" handler and avoid popping up the dialog again if the variable is set.

{
	"kernel": "6.12.94",
	"hostname": "OpenWrt",
	"system": "ARMv8 Processor rev 4",
	"model": "Spectrum SAX1V1K",
	"board_name": "spectrum,sax1v1k",
	"rootfs_type": "squashfs",
	"release": {
		"distribution": "OpenWrt",
		"version": "25.12.5",
		"firmware_url": "https://downloads.openwrt.org/",
		"revision": "r33051-f5dae5ece4",
		"target": "qualcommax/ipq807x",
		"description": "OpenWrt 25.12.5 r33051-f5dae5ece4",
		"builddate": "1782737960"
	}
}

What browsers do you see the problem on?

Firefox

Relevant log output