Skip to content

Commit 5fdcc45

Browse files
david-marchandigsilya
authored andcommitted
netdev: Remove legacy duplex API.
This API was announcing duplex capability based on a fixed list of known link speeds. It is now unneeded with the new duplex API. Acked-by: Eelco Chaudron <[email protected]> Acked-by: Mike Pattrick <[email protected]> Signed-off-by: David Marchand <[email protected]> Signed-off-by: Ilya Maximets <[email protected]>
1 parent d44849b commit 5fdcc45

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

include/openvswitch/netdev.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,6 @@ int netdev_get_features(const struct netdev *,
135135
int netdev_get_speed(const struct netdev *, uint32_t *current, uint32_t *max);
136136
uint64_t netdev_features_to_bps(enum netdev_features features,
137137
uint64_t default_bps);
138-
bool netdev_features_is_full_duplex(enum netdev_features features);
139138
int netdev_get_duplex(const struct netdev *, bool *full_duplex);
140139
int netdev_set_advertisements(struct netdev *, enum netdev_features advertise);
141140
void netdev_features_format(struct ds *, enum netdev_features);

lib/netdev.c

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1288,16 +1288,6 @@ netdev_features_to_bps(enum netdev_features features,
12881288
: default_bps);
12891289
}
12901290

1291-
/* Returns true if any of the NETDEV_F_* bits that indicate a full-duplex link
1292-
* are set in 'features', otherwise false. */
1293-
bool
1294-
netdev_features_is_full_duplex(enum netdev_features features)
1295-
{
1296-
return (features & (NETDEV_F_10MB_FD | NETDEV_F_100MB_FD | NETDEV_F_1GB_FD
1297-
| NETDEV_F_10GB_FD | NETDEV_F_40GB_FD
1298-
| NETDEV_F_100GB_FD | NETDEV_F_1TB_FD)) != 0;
1299-
}
1300-
13011291
/* Stores the duplex capability of 'netdev' into 'full_duplex'.
13021292
*
13031293
* Some network devices may not implement support for this function.

0 commit comments

Comments
 (0)