Skip to content

Conversation

@anzr299
Copy link
Collaborator

@anzr299 anzr299 commented Nov 21, 2025

Changes

Fix logic to sample activation values from the collected statistics which resolves a bug.

Reason for changes

An error was introduced with the addition of SE support for 3D weights #3706. This was spotted by the failing test https://github.com/openvinotoolkit/nncf/actions/runs/19549771001

Related tickets

Tests

  1. Extended Scale estimation test test_scale_estimation() in tests/cross_fw/test_templates/template_test_weights_compression.py to include the case where calibration dataset size > scale estimation subset size
  2. Added test_process_stats in weights compression template test for testing the process_stats function.

Example Test: https://github.com/openvinotoolkit/nncf/actions/runs/19580896526
WC Conformance Test: https://github.com/openvinotoolkit/nncf/actions/runs/19577215441

Precision Type Filter Value Stderr
INT4 SYM Per-Channel (with Scale estimation) After Fix flexible-extract 0.61 0.0490
  strict-match 0.40 0.0492
INT4 SYM Per-Channel (with Scale estimation) Before fix flexible-extract 0.66 0.0476
  strict-match 0.38 0.0488
INT4 SYM Per-Channel flexible-extract 0.77 0.0423
  strict-match 0.28 0.0451
FP16 flexible-extract 0.91 0.0288
  strict-match 0.86 0.0349

@anzr299 anzr299 requested a review from a team as a code owner November 21, 2025 16:41
@anzr299 anzr299 marked this pull request as draft November 21, 2025 17:24
@github-actions github-actions bot added NNCF OpenVINO Pull requests that updates NNCF OpenVINO NNCF ONNX Pull requests that updates NNCF ONNX labels Nov 24, 2025
@anzr299 anzr299 marked this pull request as ready for review November 24, 2025 11:01
Copy link
Collaborator

@AlexanderDokuchaev AlexanderDokuchaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test for process_stats function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NNCF ONNX Pull requests that updates NNCF ONNX NNCF OpenVINO Pull requests that updates NNCF OpenVINO

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants