-
Notifications
You must be signed in to change notification settings - Fork 270
[Data-Aware WC] Fix Statistics Processing for Data Aware Methods #3752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anzr299
wants to merge
13
commits into
openvinotoolkit:develop
Choose a base branch
from
anzr299:an/fix_algo_stats_processing
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Data-Aware WC] Fix Statistics Processing for Data Aware Methods #3752
anzr299
wants to merge
13
commits into
openvinotoolkit:develop
from
anzr299:an/fix_algo_stats_processing
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljaljushkin
approved these changes
Nov 25, 2025
AlexanderDokuchaev
requested changes
Nov 25, 2025
Collaborator
AlexanderDokuchaev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a unit test for process_stats function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
NNCF ONNX
Pull requests that updates NNCF ONNX
NNCF OpenVINO
Pull requests that updates NNCF OpenVINO
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix logic to sample activation values from the collected statistics which resolves a bug.
Reason for changes
An error was introduced with the addition of SE support for 3D weights #3706. This was spotted by the failing test https://github.com/openvinotoolkit/nncf/actions/runs/19549771001
Related tickets
Tests
test_scale_estimation()intests/cross_fw/test_templates/template_test_weights_compression.pyto include the case where calibration dataset size > scale estimation subset sizetest_process_statsin weights compression template test for testing the process_stats function.Example Test: https://github.com/openvinotoolkit/nncf/actions/runs/19580896526
WC Conformance Test: https://github.com/openvinotoolkit/nncf/actions/runs/19577215441