Skip to content

Conversation

@shenjunjian
Copy link
Collaborator

@shenjunjian shenjunjian commented Nov 25, 2025

PR

1、从saas官网的菜单中,隐藏某些组件
2、为select的部分属性,添加 hideSaas:true

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • New Features

    • Added autoSelect property to Select component for automatic selection when only one item is available.
  • Chores

    • Updated Select component documentation metadata to control visibility in different environments.
    • Adjusted component availability configuration for SaaS platform.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions github-actions bot added the bug Something isn't working label Nov 25, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 25, 2025

Walkthrough

Updates select component documentation metadata by marking SaaS-specific features with hideSaas: true across multiple files. Expands the SaaS menu exclusion list with additional components. Introduces an autoSelect boolean prop to the Select component for auto-selection when only one item exists.

Changes

Cohort / File(s) Summary
SaaS Documentation Metadata
examples/sites/demos/apis/select.js, examples/sites/demos/pc/app/select/webdoc/select.js
Added hideSaas: true to prop/demo metadata for: all-text, show-all-text-tag, clear-no-match-value, input-box-type, collapse-tags, searchable, slot-reference, no-data-text, show-proportion, show-limit-text, tag-type, max-tag-width; minor text updates noting non-SaaS attributes
SaaS Menu Configuration
examples/sites/demos/saas/menus.js
Extended noSaasComponents exclusion list to include DatePanel, Space, BaseSelect, FluentEditor, TreeSelect, GridSelect, ConfigProvider, and Skeleton
Select Component Props
packages/vue/src/select/src/index.ts
Added new autoSelect boolean prop (default: false) with SaaS-specific auto-selection logic when single item exists

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Repetitive metadata additions follow consistent patterns across files
  • Menu list expansion is straightforward array extension
  • Single new prop with minimal logic impact; verify prop type and default value alignment

Poem

🐰✨ Hidden features tucked away so clean,
SaaS and non-SaaS, now serene,
Select grows wise with auto-choice,
Components organized, all rejoice! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main intent: hiding certain properties in SaaS mode. The changes across multiple files consistently add hideSaas: true metadata and exclude components from SaaS menus, directly aligning with this objective.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch shen/hide-select-props

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 94f7b91 and 85c47a0.

📒 Files selected for processing (4)
  • examples/sites/demos/apis/select.js (12 hunks)
  • examples/sites/demos/pc/app/select/webdoc/select.js (9 hunks)
  • examples/sites/demos/saas/menus.js (1 hunks)
  • packages/vue/src/select/src/index.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (3)
examples/sites/demos/apis/select.js (1)

19-20: LGTM! Documentation metadata updates are consistent.

The hideSaas: true additions across multiple prop and slot entries align with the PR objective to hide certain Select component features from the SaaS website documentation. These are metadata-only changes with no functional impact.

Also applies to: 33-34, 98-99, 242-243, 292-293, 515-516, 540-541, 578-579, 593-594, 682-683, 696-697, 919-920

examples/sites/demos/pc/app/select/webdoc/select.js (1)

31-31: LGTM! Demo metadata and descriptions updated correctly.

The additions of hideSaas: true to demo entries and the updated descriptions mentioning "非saas属性" (non-SaaS attribute) are consistent with the PR's goal to differentiate SaaS-specific documentation visibility.

Also applies to: 53-53, 89-90, 182-183, 237-238, 265-266, 358-358, 623-624, 655-656

examples/sites/demos/saas/menus.js (1)

9-9: LGTM! SaaS menu exclusion list expanded appropriately.

The addition of DatePanel and seven other components (Space, BaseSelect, FluentEditor, TreeSelect, GridSelect, ConfigProvider, Skeleton) to the noSaasComponents exclusion list aligns with the PR objective. The trailing comma after Statistic improves maintainability.

Also applies to: 16-23


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants