Merge pull request #311 from opensource-challenge/dependency-updates

update dependencies and resolve deprication warnings

Author: olibrian

.travis.yml

@@ -27,4 +27,5 @@ env:
     - PERCY_PROJECT=opensource-challenge/opensource-challenge-client
     - secure: PkKoqLSXvLiCmD8dzPVw/klJ6QfT4y4Unl6sWwDZZH5mrGDT1/vqdR8lS4G9X65ICQg27rRVwly6tv5o+sXQFQlXMpEiGO7RXncIHHMRD/sF3PTnGVopyQq1jFHqFEHOAbKXvwVRuIilUR+OGhdyLk6NHt+/9MgHSR2Y0+B1XxheC6eltRUsdzYCQiT7U5WBaeGpIznkCLithtc7VsZudbnsR3iVuKVvpKXOQ5MJabyrS3lR7onfyzRmqwQKx7Mc0DaLFalO0UnwO3z09K/ER30nzrHTR9hNEh8DUItsxELQKGU4AxOw3AsexJkbhpwdNSt3+4F5uOh0+YnqMYcn7EPXv4OWVK6bNpe/UUxppuwTSSdrnbM1EB79kZn5jyZLrC0Q6x+X1vF70mlz/GYQ3IySVk1zKny7GkxpCnmjoAM90CzK9NoqRhYYDKBegWeRXSGCG4P5nqyo73ic1JLmnOTWw/IYb97JEFXc1vIySTqleqUj+q6DHleJ+6Fls6IBUCMr3HXsj5VXfnwSlxRMB3gu9RgNQIr4Z8UK7zsWTgvmK6ZOzabeIyf74kMgrbmh8rJSY4vDEHnwxfq2DyVHc4/XjTVeJF40WgAdu2XjB75MefrZLLrTDDhdxCzL1vBiIWdpWsswp3gMkdCJaJ8EsThh7Luy5G6OreJb6Ibo3yw=
   matrix:
-    - COVERAGE=true CODECLIMATE_REPO_TOKEN=9e087f07cf44e07584de87390bc3e55de61e1523afe675df9c8f4d6ba7fba38b
+    # Disable coverage for now (See https://github.com/kategengler/ember-cli-code-coverage/issues/296)
+    - COVERAGE=false CODECLIMATE_REPO_TOKEN=9e087f07cf44e07584de87390bc3e55de61e1523afe675df9c8f4d6ba7fba38b

app/adapters/application.js

@@ -2,10 +2,9 @@ import { assign } from '@ember/polyfills'
 import { inject as service } from '@ember/service'
 import { isPresent } from '@ember/utils'
 import ENV from '../config/environment'
-import DS from 'ember-data'
+import JSONAPIAdapter from '@ember-data/adapter/json-api'
 import DataAdapterMixin from 'ember-simple-auth/mixins/data-adapter-mixin'
 
-const { JSONAPIAdapter } = DS
 const TIMEOUT = 10000
 
 export default JSONAPIAdapter.extend(DataAdapterMixin, {

app/components/calendar-entry/component.js

@@ -8,6 +8,6 @@ export default Component.extend({
     'https://www.puzzle.ch/wp-content/uploads/2015/11/Tux-960x720.jpg',
 
   picture: computed('item.user.picture', function() {
-    return this.getWithDefault('item.user.picture', this.fallbackPicture)
+    return this.get('item.user.picture') || this.fallbackPicture
   }),
 })

app/components/calendar-entry/template.hbs

@@ -1,7 +1,7 @@
 {{#with this.item.user as |user|}}
   <header>
     {{#link-to "contributors.profile" user class="avatar-wrapper"}}
-      <img class="avatar" src={{this.picture}} alt="">
+      <img class="avatar" src={{this.picture}} alt="avatar">
       <div class="username">{{user.name}}</div>
     {{/link-to}}
   </header>

app/components/contribution-calendar/component.js

@@ -6,12 +6,18 @@ import groupBy from '../../utils/group-by-macro'
 
 export default Component.extend({
   archive: null,
-
-  challenge: computed(() => ({
-    startsOn: '2100-12-01',
-    endsOn: '2100-12-24',
-    active: true,
-  })),
+  _challenge: null,
+
+  set challenge(value) {
+    this._challenge = value
+  },
+  get challenge() {
+    return this._challenge || {
+      startsOn: '2100-12-01',
+      endsOn: '2100-12-24',
+      active: true,
+    }
+  },
 
   sortedItems: sort(
     'items.[]',

app/components/contributor-list/template.hbs

@@ -14,7 +14,7 @@
       <img
         class="contributor__image hover-box__content"
         src={{contributor.picture}}
-        alt=""
+        alt="contributor"
       >
     {{/link-to}}
   </div>

app/components/display-error/template.hbs

@@ -1,5 +1,5 @@
 {{#if this.messageIsHTMLDocument}}
-  <iframe srcdoc={{this.error.message}}></iframe>
+  <iframe srcdoc={{this.error.message}} title="error message"></iframe>
 {{else if this.error.isAdapterError}}
   <pre class="error">{{this.error.message}}</pre>
 {{else if this.error.errors}}
@@ -18,7 +18,7 @@
 {{/if}}
 
 {{#if this.error.stack}}
-  <button class="btn-primary" onclick={{toggle "showStack" this}}>
+  <button class="btn-primary" onclick={{toggle "showStack" this}} type="button">
     Show stack
   </button>
 

app/models/challenge.js

@@ -1,5 +1,4 @@
 import { not } from '@ember/object/computed'
-import { computed } from '@ember/object'
 import DS from 'ember-data'
 
 const { Model, attr, hasMany } = DS
@@ -11,10 +10,8 @@ export default Model.extend({
   startsOn: attr('date'),
   endsOn: attr('date'),
   closed: attr('boolean'),
-
-  active: computed('startsOn', function() {
+  get active() {
     return Date.now() >= this.startsOn
-  }).volatile(),
-
+  },
   open: not('closed').readOnly(),
 })

app/templates/contributors/profile.hbs

@@ -1,7 +1,7 @@
 <section class="content content-padding">
   <div class="layout-row contributor-profile-details">
     {{#with this.model.picture as |picture|}}
-      <img class="contributor-profile-picture" src={{picture}} alt="">
+      <img class="contributor-profile-picture" src={{picture}} alt="contributor">
     {{/with}}
     <div>
       <h1>{{this.model.name}}</h1>

app/templates/login.hbs

@@ -6,7 +6,7 @@
       {{f.submit "Login"}}
     {{/form-for--}}
     <p class="text-center">
-      <button class="btn-primary" onclick={{route-action "loginWithGithub"}}>
+      <button class="btn-primary" onclick={{route-action "loginWithGithub"}} type="button">
         {{fa-icon "github"}} Login with Github
       </button>
     </p>