Skip to content

Update Kueue install mode to OwnNamespace #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update Kueue install mode to OwnNamespace #803

wants to merge 1 commit into from
+5 −5

Conversation

@MaysaMacedo
Copy link
Contributor

@MaysaMacedo MaysaMacedo commented Oct 7, 2025 •
edited
Loading

Right now the CSV permissions are "promoted" to ClusterRoles when the operator is installed with AllNamespaces mode, so let's avoid having a clusterRole and role being created for the same resource, as an example network policy.
Also, our operator does not need to watch events on all namespaces, so let's change it to OwnNamespace.

@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Oct 7, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2025
@MaysaMacedo MaysaMacedo changed the title Update Kueue install mode to OwnNamespace wip: Update Kueue install mode to OwnNamespace Oct 7, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2025
@openshift-ci openshift-ci bot requested review from kannon92 and mrunalp October 7, 2025 19:49
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2025
@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Oct 7, 2025

/retest

@MaysaMacedo MaysaMacedo changed the title wip: Update Kueue install mode to OwnNamespace Update Kueue install mode to OwnNamespace Oct 10, 2025
@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Oct 10, 2025

/retest

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 10, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2025
@MaysaMacedo
Update Kueue install mode to OwnNamespace
b7d95d4 
Our operator does not need to watch events on all namespaces,
so let's change it to OwnNamespace.
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2025
@MaysaMacedo
Copy link
Contributor Author

MaysaMacedo commented Oct 13, 2025

/hold cancel
here are some docs related to this https://olm.operatorframework.io/docs/advanced-tasks/operator-scoping-with-operatorgroups/#targetnamespaces-and-their-relationship-to-installmodes

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2025
kannon92
kannon92 reviewed Oct 14, 2025
View reviewed changes
Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2025
@openshift-ci
Copy link

openshift-ci bot commented Oct 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MaysaMacedo,kannon92]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 14, 2025
@openshift-merge-robot
Copy link

openshift-merge-robot commented Oct 14, 2025

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kannon92
Copy link
Contributor

kannon92 commented Nov 6, 2025

/hold

It sounds like using OwnNamespace could cause issues with OLM V1.

We should probably wait on this one.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2025
@openshift-ci
Copy link

openshift-ci bot commented Dec 1, 2025

@MaysaMacedo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-e2e-upstream-4-20 b7d95d4 link true /test test-e2e-upstream-4-20
ci/prow/test-e2e-downstream-4-20 b7d95d4 link true /test test-e2e-downstream-4-20

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kannon92 kannon92 kannon92 left review comments

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@kannon92 kannon92

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MaysaMacedo @openshift-merge-robot @kannon92