Skip to content

Conversation

@tkashem
Copy link
Contributor

@tkashem tkashem commented May 1, 2025

No description provided.

@openshift-ci openshift-ci bot requested review from cpmeadors and rphillips May 1, 2025 18:58
README.md Outdated

This label instructs the Kueue Operator that the namespace should be managed by its webhook admission controllers. As a result, any Kueue resources within that namespace will be properly validated and mutated.

### Debugging
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Debugging
### Running operator locally with Kind

This isn't really debugging..

@kannon92
Copy link
Contributor

kannon92 commented May 1, 2025

LGTM.

This is similar to what @rphillips was also working on.

@kannon92
Copy link
Contributor

kannon92 commented May 1, 2025

#115

Copy link
Contributor

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2025
@openshift-ci
Copy link

openshift-ci bot commented May 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2025
@kannon92
Copy link
Contributor

kannon92 commented May 9, 2025

/override ci/prow/test-e2e-e2e-4-17

@openshift-ci
Copy link

openshift-ci bot commented May 9, 2025

@kannon92: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ci/prow/test-e2e-e2e-4-17

Only the following failed contexts/checkruns were expected:

  • ci/prow/images
  • ci/prow/lint
  • ci/prow/test
  • ci/prow/test-e2e-4-17
  • ci/prow/test-e2e-4-18
  • ci/prow/test-e2e-upstream-4-17
  • ci/prow/test-e2e-upstream-4-18
  • ci/prow/test-generate
  • pull-ci-openshift-kueue-operator-main-images
  • pull-ci-openshift-kueue-operator-main-lint
  • pull-ci-openshift-kueue-operator-main-test
  • pull-ci-openshift-kueue-operator-main-test-e2e-4-17
  • pull-ci-openshift-kueue-operator-main-test-e2e-4-18
  • pull-ci-openshift-kueue-operator-main-test-e2e-upstream-4-17
  • pull-ci-openshift-kueue-operator-main-test-e2e-upstream-4-18
  • pull-ci-openshift-kueue-operator-main-test-generate
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ci/prow/test-e2e-e2e-4-17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 13d7e70 and 2 for PR HEAD 125c47c in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 13d7e70 and 2 for PR HEAD 125c47c in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b41eddf and 1 for PR HEAD 125c47c in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b41eddf and 2 for PR HEAD 125c47c in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b41eddf and 2 for PR HEAD 125c47c in total

@kannon92
Copy link
Contributor

Can you retarget this for release-1.0?

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2a8c5d5 and 1 for PR HEAD 125c47c in total

@cpmeadors
Copy link
Contributor

@tkashem is this still valid?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link

openshift-ci bot commented Dec 1, 2025

@tkashem: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-e2e-4-17 125c47c link true /test test-e2e-4-17
ci/prow/test-e2e-4-20 125c47c link true /test test-e2e-4-20
ci/prow/test-e2e-downstream-4-20 125c47c link true /test test-e2e-downstream-4-20
ci/prow/test-e2e-upstream-4-20 125c47c link true /test test-e2e-upstream-4-20

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants