replaced nameRegex with bitBucketUserNameRegex, err.type required, subject.name

Author: krishagarwal278

frontend/packages/dev-console/src/components/project-access/__tests__/project-access-form-data.ts

@@ -3,7 +3,10 @@ import { UserRoleBinding, RoleBinding } from '../project-access-form-utils-types
 export const mockProjectAccessData = {
   projectAccess: [
     {
-      user: 'abc',
+      subject: {
+        name: 'abc',
+        kind: 'User',
+      },
       role: 'view',
     },
   ],

frontend/packages/dev-console/src/components/project-access/__tests__/project-access-form-validation-utils.spec.ts

@@ -5,12 +5,12 @@ import { mockProjectAccessData } from './project-access-form-data';
 describe('ValidationUtils', () => {
   it('should throw an error if Name field is empty', async () => {
     const mockData = cloneDeep(mockProjectAccessData);
-    mockData.projectAccess[0].user = '';
+    mockData.projectAccess[0].subject.name = '';
 
     await validationSchema.isValid(mockData).then((valid) => expect(valid).toEqual(false));
     await validationSchema.validate(mockData).catch((err) => {
       expect(err.message).toBe('Required');
-      expect(err.type).toBe('optionality');
+      expect(err.type).toBe('required');
     });
   });
 

frontend/packages/pipelines-plugin/src/components/repository/repository-form-utils.ts

@@ -83,9 +83,9 @@ export const pipelinesAccessTokenValidationSchema = (t: TFunction) =>
           schema.shape({
             user: yup
               .string()
-              .matches(nameRegex, {
+              .matches(bitBucketUserNameRegex, {
                 message: t(
-                  'pipelines-plugin~Name must consist of lower-case letters, numbers and hyphens. It must start with a letter and end with a letter or number.',
+                  'pipelines-plugin~Name must consist of lower-case letters, numbers, underscores and hyphens. It must start with a letter and end with a letter or number.',
                 ),
                 excludeEmptyString: true,
               })