CONSOLE-3769: Remove null checks from DynamicPluginInfo

because we know it will never be null

Author: logonoff

frontend/packages/console-app/src/components/console-operator/ConsoleOperatorConfig.tsx

@@ -302,7 +302,7 @@ const DevPluginsPage: React.FCC<ConsoleOperatorConfigPageProps> = (props) => {
   const rows = React.useMemo<ConsolePluginTableRow[]>(
     () =>
       pluginInfo
-        .filter((plugin) => plugin?.status === 'loaded')
+        .filter((plugin) => plugin.status === 'loaded')
         .map((plugin) => ({
           name: plugin.metadata.name,
           version: plugin.metadata.version,
@@ -336,10 +336,10 @@ const PluginsPage: React.FC<ConsoleOperatorConfigPageProps> = (props) => {
       const pluginName = plugin?.metadata?.name;
       const enabled = enabledPlugins.includes(pluginName);
       const loadedPluginInfo = pluginInfo
-        .filter((p) => p?.status === 'loaded')
+        .filter((p) => p.status === 'loaded')
         .find((i) => i?.metadata?.name === pluginName);
       const notLoadedPluginInfo = pluginInfo
-        .filter((p) => p?.status !== 'loaded')
+        .filter((p) => p.status !== 'loaded')
         .find((i) => i?.pluginName === pluginName);
       if (loadedPluginInfo) {
         return {

frontend/packages/console-app/src/components/console-operator/ConsolePluginDescriptionDetail.tsx

@@ -10,7 +10,7 @@ const ConsolePluginDescriptionDetail: React.FC<DetailsItemComponentProps> = ({ o
   const pluginInfo = React.useMemo(
     () =>
       pluginInfoEntries.find((entry) =>
-        entry?.status === 'loaded'
+        entry.status === 'loaded'
           ? entry.metadata.name === pluginName
           : entry.pluginName === pluginName,
       ),

frontend/packages/console-app/src/components/console-operator/ConsolePluginEnabledStatusDetail.tsx

@@ -17,7 +17,7 @@ const ConsolePluginEnabledStatusDetail: React.FC<DetailsItemComponentProps> = ({
   const pluginInfo = React.useMemo(
     () =>
       pluginInfoEntries.find((entry) =>
-        entry?.status === 'loaded'
+        entry.status === 'loaded'
           ? entry.metadata.name === pluginName
           : entry.pluginName === pluginName,
       ),

frontend/packages/console-app/src/components/console-operator/ConsolePluginStatusDetail.tsx

@@ -11,7 +11,7 @@ const ConsolePluginStatusDetail: React.FC<DetailsItemComponentProps> = ({ obj })
   const pluginInfo = React.useMemo(
     () =>
       pluginInfoEntries.find((entry) =>
-        entry?.status === 'loaded'
+        entry.status === 'loaded'
           ? entry.metadata.name === pluginName
           : entry.pluginName === pluginName,
       ),

frontend/packages/console-app/src/components/console-operator/ConsolePluginVersionDetail.tsx

@@ -11,7 +11,7 @@ const ConsolePluginVersionDetail: React.FC<DetailsItemComponentProps> = ({ obj }
   const pluginInfo = React.useMemo(
     () =>
       pluginInfoEntries.find((entry) =>
-        entry?.status === 'loaded'
+        entry.status === 'loaded'
           ? entry.metadata.name === pluginName
           : entry.pluginName === pluginName,
       ),

frontend/packages/console-app/src/components/dashboards-page/dynamic-plugins-health-resource/DynamicPluginsPopover.tsx

@@ -19,11 +19,11 @@ const DynamicPluginsPopover: React.FC<DynamicPluginsPopoverProps> = ({ consolePl
     UI.get('pluginCSPViolations'),
   );
   const notLoadedDynamicPluginInfo = pluginInfoEntries.filter(
-    (plugin) => plugin?.status !== 'loaded',
+    (plugin) => plugin.status !== 'loaded',
   );
   const failedPlugins = notLoadedDynamicPluginInfo.filter((plugin) => plugin.status === 'failed');
   const pendingPlugins = notLoadedDynamicPluginInfo.filter((plugin) => plugin.status === 'pending');
-  const loadedPlugins = pluginInfoEntries.filter((plugin) => plugin?.status === 'loaded');
+  const loadedPlugins = pluginInfoEntries.filter((plugin) => plugin.status === 'loaded');
   const loadedPluginsWithCSPViolations = loadedPlugins.filter(
     (plugin) => cspViolations[plugin.metadata.name] ?? false,
   );

frontend/packages/console-app/src/hooks/useCSPViolationDetector.tsx

@@ -103,7 +103,7 @@ export const useCSPViolationDetector = () => {
         const pluginInfo = pluginStore
           .getPluginInfo()
           .find((entry) =>
-            entry?.status === 'loaded'
+            entry.status === 'loaded'
               ? entry.metadata.name === pluginName
               : entry.pluginName === pluginName,
           );

frontend/public/components/about-modal.tsx

@@ -36,7 +36,7 @@ const DynamicPlugins: React.FC = () => {
   const [items, setItems] = React.useState([]);
 
   React.useEffect(() => {
-    const loadedPlugins = pluginInfoEntries.filter((plugin) => plugin?.status === 'loaded');
+    const loadedPlugins = pluginInfoEntries.filter((plugin) => plugin.status === 'loaded');
     const sortedLoadedPlugins = loadedPlugins.sort((a, b) =>
       a.metadata.name.localeCompare(b.metadata.name),
     );

frontend/public/components/app-contents.tsx

@@ -160,7 +160,7 @@ const AppContents: React.FC<{}> = () => {
   const [pluginPageRoutes, inactivePluginPageRoutes] = usePluginRoutes();
 
   const allPluginsProcessed = React.useMemo(
-    () => pluginInfoEntries.every((i) => i?.status !== 'pending'),
+    () => pluginInfoEntries.every((i) => i.status !== 'pending'),
     [pluginInfoEntries],
   );
 

frontend/public/components/notification-drawer.tsx

@@ -162,7 +162,7 @@ const getUpdateNotificationEntries = (
   const newerChannelVersion = splitClusterVersionChannel(newerChannel)?.version;
   const entries = [];
 
-  const failedPlugins = pluginInfoEntries.filter((plugin) => plugin?.status === 'failed');
+  const failedPlugins = pluginInfoEntries.filter((plugin) => plugin.status === 'failed');
 
   if (!_.isEmpty(updateData)) {
     entries.push(