CONSOLE-4858: Remove get-active-plugins filter

These cycles will be addressed by CONSOLE-4806 and CONSOLE-4840

Author: logonoff

frontend/packages/console-app/src/plugin.tsx

@@ -1,5 +1,3 @@
-import '@console/internal/i18n.js';
-import '@console/shared/src/index.ts'; // this import is load bearing in development?!?!
 import { GuidedTour, Plugin } from '@console/plugin-sdk';
 import { getGuidedTour } from './components/guided-tour';
 

frontend/public/components/RBAC/role-type.ts

@@ -3,8 +3,6 @@ import type { K8sResourceKind } from '../../module/k8s/types';
 
 export const isSystemRole = (role: K8sResourceKind) => _.startsWith(role.metadata.name, 'system:');
 
-// const addHref = (name, ns) => ns ? `/k8s/ns/${ns}/roles/${name}/add-rule` : `/k8s/cluster/clusterroles/${name}/add-rule`;
-
 export const roleKind = (role: K8sResourceKind) =>
   role.metadata.namespace ? 'Role' : 'ClusterRole';
 

frontend/public/locales/en/public.json

@@ -380,6 +380,8 @@
   "{{readyReplicas}} of {{count}} machine_one": "{{readyReplicas}} of {{count}} machine",
   "{{readyReplicas}} of {{count}} machine_other": "{{readyReplicas}} of {{count}} machines",
   "Create {{objLabel}}": "Create {{objLabel}}",
+  "Terminating": "Terminating",
+  "CrashLoopBackOff": "CrashLoopBackOff",
   "CronJob details": "CronJob details",
   "Schedule": "Schedule",
   "Suspend": "Suspend",
@@ -585,14 +587,14 @@
   "Showing most recent {{count}} event_one": "Showing most recent {{count}} event",
   "Showing most recent {{count}} event_other": "Showing most recent {{count}} events",
   "Older events are not stored.": "Older events are not stored.",
-  "Filter {{label}}...": "Filter {{label}}...",
   "Create {{label}}": "Create {{label}}",
   "by name": "by name",
   "Submit": "Submit",
   "Reset": "Reset",
   "Row select": "Row select",
   "Actions": "Actions",
   "Export as CSV": "Export as CSV",
+  "Filter {{label}}...": "Filter {{label}}...",
   "Label": "Label",
   "Clear all filters": "Clear all filters",
   "Filter": "Filter",
@@ -1094,7 +1096,6 @@
   "Notifications in the other alerts group": "Notifications in the other alerts group",
   "Recommendations": "Recommendations",
   "Notifications in the recommendations group": "Notifications in the recommendations group",
-  "Terminating": "Terminating",
   "No PersistentVolume": "No PersistentVolume",
   "Used": "Used",
   "Total": "Total",
@@ -1121,7 +1122,18 @@
   "Reconnect": "Reconnect",
   "Connecting to": "Connecting to",
   "Collapse": "Collapse",
+  "Ready": "Ready",
+  "Owner": "Owner",
+  "IP address": "IP address",
   "Receiving Traffic": "Receiving Traffic",
+  "{{numCores}} cores": "{{numCores}} cores",
+  "Pod unschedulable": "Pod unschedulable",
+  "Pod crash loop back-off": "Pod crash loop back-off",
+  "CrashLoopBackOff indicates that the application within the container is failing to start properly.": "CrashLoopBackOff indicates that the application within the container is failing to start properly.",
+  "To troubleshoot, view logs and events, then debug in terminal.": "To troubleshoot, view logs and events, then debug in terminal.",
+  "View events": "View events",
+  "Debug container {{name}}": "Debug container {{name}}",
+  "Create Pod": "Create Pod",
   "Not Receiving Traffic": "Not Receiving Traffic",
   "Log in to your account": "Log in to your account",
   "Log in": "Log in",
@@ -1130,10 +1142,6 @@
   "Login is required. Please try again.": "Login is required. Please try again.",
   "Could not check CSRF token. Please try again.": "Could not check CSRF token. Please try again.",
   "Invalid login or password. Please try again.": "Invalid login or password. Please try again.",
-  "Ready": "Ready",
-  "Owner": "Owner",
-  "IP address": "IP address",
-  "{{numCores}} cores": "{{numCores}} cores",
   "since <1></1>": "since <1></1>",
   "at <1></1> ": "at <1></1> ",
   "with exit code {{exitCode}} ": "with exit code {{exitCode}} ",
@@ -1143,21 +1151,13 @@
   "Terminated <1></1><2></2><3></3>": "Terminated <1></1><2></2><3></3>",
   "Exit code": "Exit code",
   "View in query browser": "View in query browser",
-  "Pod unschedulable": "Pod unschedulable",
-  "Pod crash loop back-off": "Pod crash loop back-off",
-  "CrashLoopBackOff indicates that the application within the container is failing to start properly.": "CrashLoopBackOff indicates that the application within the container is failing to start properly.",
-  "To troubleshoot, view logs and events, then debug in terminal.": "To troubleshoot, view logs and events, then debug in terminal.",
-  "View events": "View events",
-  "Debug container {{name}}": "Debug container {{name}}",
   "Restart policy": "Restart policy",
   "Pod IPs": "Pod IPs",
   "Host IPs": "Host IPs",
   "Host IP": "Host IP",
   "Image pull secret": "Image pull secret",
   "Pod details": "Pod details",
   "Init containers": "Init containers",
-  "CrashLoopBackOff": "CrashLoopBackOff",
-  "Create Pod": "Create Pod",
   "Web console update is available": "Web console update is available",
   "There has been an update to the web console. Ensure any changes have been saved and refresh your browser to access the latest version.": "There has been an update to the web console. Ensure any changes have been saved and refresh your browser to access the latest version.",
   "Refresh web console": "Refresh web console",

frontend/webpack.circular-deps.ts

@@ -12,8 +12,6 @@ const HandleCyclesPluginName = 'HandleCyclesPlugin';
 type PresetOptions = {
   /** Exclude modules that match the given regex */
   exclude?: RegExp;
-  /** Ignores cycles that involve modules matching the given regex */
-  filterModules?: RegExp;
   /** Path to write the cycle report to */
   reportFile: string;
   /** Thresholds for the number of cycles detected before emitting an error */
@@ -120,12 +118,7 @@ export class CircularDependencyPreset {
       new CircularDependencyPlugin({
         exclude: this.options.exclude,
         onDetected: ({ module: { resource }, paths: modulePaths }) => {
-          if (
-            !this.options.filterModules ||
-            !modulePaths.some((p) => this.options.filterModules.test(p))
-          ) {
-            cycles.push({ causedBy: resource, modulePaths });
-          }
+          cycles.push({ causedBy: resource, modulePaths });
         },
       }),
       {

frontend/webpack.config.ts

@@ -340,10 +340,7 @@ const config: Configuration = {
 if (CHECK_CYCLES === 'true') {
   new CircularDependencyPreset({
     exclude: /node_modules|public\/dist|\.(gql|html)$/,
-    // TODO: investigate how to load the plugins registry asynchronously
-    filterModules: /^get-active-plugins\.js$/,
-    // TODO: Fix cycles unveiled by CONSOLE-4837, then remove the below line
-    thresholds: { totalCycles: 10 },
+    thresholds: { totalCycles: 21 }, // TODO(CONSOLE-4806): Set threshold to 0
     reportFile: '.webpack-cycles',
   }).apply(config.plugins);
 }