added more cases

Author: miyadav

e2e/machine_migration_vap_tests.go

@@ -28,7 +28,6 @@ const (
 	testAvailabilityZone      = "us-west-2b"
 	testSubnetID              = "subnet-test123456"
 	testSecurityGroupID       = "sg-test123456"
-	testVolumeSize            = int64(120)
 	testCapacityReservationID = "cr-test123456"
 
 	// VAP error messages - from actual VAP policy
@@ -139,6 +138,39 @@ var _ = Describe("[sig-cluster-lifecycle][OCPFeatureGate:MachineAPIMigration] MA
 			})
 		})
 
+		Context("AWS provider spec field restrictions", func() {
+			It("should prevent updating providerSpec.instanceType", func() {
+				verifyAWSProviderSpecUpdatePrevented(testMAPIMachine, "instanceType", testInstanceType, vapSpecLockedMessage)
+			})
+
+			It("should prevent updating providerSpec.amiID", func() {
+				verifyAWSProviderSpecUpdatePrevented(testMAPIMachine, "amiID", testAMIID, vapSpecLockedMessage)
+			})
+
+			It("should prevent updating providerSpec.availabilityZone", func() {
+				verifyAWSProviderSpecUpdatePrevented(testMAPIMachine, "availabilityZone", testAvailabilityZone, vapSpecLockedMessage)
+			})
+
+			It("should prevent updating providerSpec.subnetID", func() {
+				verifyAWSProviderSpecUpdatePrevented(testMAPIMachine, "subnetID", testSubnetID, vapSpecLockedMessage)
+			})
+
+			It("should prevent updating providerSpec.securityGroups", func() {
+				verifyAWSProviderSpecUpdatePrevented(testMAPIMachine, "securityGroups", testSecurityGroupID, vapSpecLockedMessage)
+			})
+
+			It("should prevent updating providerSpec.tags", func() {
+				testTags := map[string]string{
+					"test-key": "test-value",
+				}
+				verifyAWSProviderSpecUpdatePrevented(testMAPIMachine, "tags", testTags, vapSpecLockedMessage)
+			})
+
+			It("should prevent updating providerSpec.capacityReservationId", func() {
+				verifyAWSProviderSpecUpdatePrevented(testMAPIMachine, "capacityReservationId", testCapacityReservationID, vapSpecLockedMessage)
+			})
+		})
+
 		Context("VAP match conditions verification", func() {
 			It("should not apply VAP when authoritativeAPI is MachineAPI", func() {
 				verifyVAPNotAppliedForMachineAPIAuthority()
@@ -207,24 +239,6 @@ func verifyAWSProviderSpecUpdatePrevented(machine *mapiv1beta1.Machine, fieldNam
 			providerSpec.SecurityGroups = []mapiv1beta1.AWSResourceReference{{
 				ID: &[]string{testValue.(string)}[0],
 			}}
-		case "volumeSize":
-			if len(providerSpec.BlockDevices) > 0 {
-				if providerSpec.BlockDevices[0].EBS != nil {
-					providerSpec.BlockDevices[0].EBS.VolumeSize = &[]int64{testValue.(int64)}[0]
-				}
-			}
-		case "volumeType":
-			if len(providerSpec.BlockDevices) > 0 {
-				if providerSpec.BlockDevices[0].EBS != nil {
-					providerSpec.BlockDevices[0].EBS.VolumeType = &[]string{testValue.(string)}[0]
-				}
-			}
-		case "encryption":
-			if len(providerSpec.BlockDevices) > 0 {
-				if providerSpec.BlockDevices[0].EBS != nil {
-					providerSpec.BlockDevices[0].EBS.Encrypted = &[]bool{testValue.(bool)}[0]
-				}
-			}
 		case "tags":
 			// Convert map to TagSpecification slice
 			tagMap := testValue.(map[string]string)