aggregation: remove Cluster should remain functional during upgrade from always passing

[stbenjam]

This test was previously excluded from aggregation because it would fail alongside other results, so we didn't need to aggregate this one (I think that was the reasoning).

https://prow.ci.openshift.org/view/gs/test-platform-results/logs/aggregated-aws-ovn-upgrade-4.21-micro-fips-release-openshift-release-analysis-aggregator/1991442012515078144 is an example where it failed 8x alone and we didn't aggregate it or catch the problem.

The only reason we caught the problem was openshift/origin#30509, the ClusterOperators test does not always run so we failed on missing results, rather than the actual failing test.

[openshift-ci-robot]

Pipeline controller notification
This repository is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. Review these jobs and use /test <job> to manually trigger optional jobs most likely to be impacted by the proposed changes.

[coderabbitai]

Walkthrough

A special-case filter in the testShouldAlwaysPass function was removed that previously excluded tests containing "Cluster should remain functional during upgrade" from aggregation. This test now falls through to remaining checks and is evaluated normally.

Changes

Cohort / File(s)	Change Summary
Test aggregation logic refactoring pkg/jobrunaggregator/jobrunaggregatoranalyzer/pass_fail.go	Removed special-case handling that filtered out tests named "Cluster should remain functional during upgrade". This test will now be subject to normal evaluation flow instead of being implicitly ignored in pass/fail aggregation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify the removal of this special-case was intentional and aligns with updated test handling expectations
• Confirm no other code paths or test suites depend on this implicit filtering behavior
• Validate that the test will correctly flow through remaining checks and produce expected aggregation outcomes

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between ebcc983 and 52598c0.

📒 Files selected for processing (1)

• pkg/jobrunaggregator/jobrunaggregatoranalyzer/pass_fail.go (0 hunks)

💤 Files with no reviewable changes (1)

• pkg/jobrunaggregator/jobrunaggregatoranalyzer/pass_fail.go

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[smg247]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smg247, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/jobrunaggregator/OWNERS [smg247]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

Scheduling required tests:
/test e2e

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test integration-optional-test

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD df6941f and 2 for PR HEAD 52598c0 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9ce2f07 and 1 for PR HEAD 52598c0 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 9c21923 and 0 for PR HEAD 52598c0 in total

[openshift-ci]

@stbenjam: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/breaking-changes	52598c0	link	false	/test breaking-changes
ci/prow/images	52598c0	link	true	/test images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

/hold

Revision 52598c0 was retested 3 times: holding