refactor: Inline local variable assignments before return/throw

Use this link to re-run the recipe: https://app.moderne.io/recipes/org.openrewrite.staticanalysis.InlineVariable?organizationId=ODQ2MGExMTUtNDg0My00N2EwLTgzMGMtNGE1NGExMTBmZDkw

Co-authored-by: Moderne <[email protected]>

Author: 2 people

src/main/java/org/openrewrite/java/spring/boot2/ChangeEmbeddedServletContainerCustomizer.java

@@ -50,7 +50,7 @@ public TreeVisitor<?, ExecutionContext> getVisitor() {
             public J.ClassDeclaration visitClassDeclaration(J.ClassDeclaration classDecl, ExecutionContext ctx) {
                 J.ClassDeclaration c = super.visitClassDeclaration(classDecl, ctx);
 
-                c = c.withImplements(
+                return c.withImplements(
                         ListUtils.map(c.getImplements(), i -> {
                             if (TypeUtils.isOfClassType(i.getType(), DEPRECATED_INTERFACE_FQN)) {
                                 maybeAddImport("org.springframework.boot.web.server.WebServerFactoryCustomizer");
@@ -61,8 +61,6 @@ public J.ClassDeclaration visitClassDeclaration(J.ClassDeclaration classDecl, Ex
                             return i;
                         })
                 );
-
-                return c;
             }
 
             private J.ParameterizedType getWebFactoryCustomizerIdentifier(ExecutionContext ctx) {

src/main/java/org/openrewrite/java/spring/boot2/OutputCaptureExtension.java

@@ -142,8 +142,7 @@ public J.MethodInvocation visitMethodInvocation(J.MethodInvocation method, Execu
                     .javaParser(JavaParser.fromJavaVersion()
                             .classpathFromResources(ctx, "spring-boot-test-2.*", "junit-jupiter-api-5.*"))
                     .build();
-            m = matchesTemplate.apply(getCursor(), m.getCoordinates().replace(), m.getArguments().get(0), variableName);
-            return m;
+            return matchesTemplate.apply(getCursor(), m.getCoordinates().replace(), m.getArguments().get(0), variableName);
         }
     }
 

src/main/java/org/openrewrite/java/spring/util/concurrent/ListenableToCompletableFuture.java

@@ -30,10 +30,9 @@ public J.CompilationUnit visitCompilationUnit(J.CompilationUnit compilationUnit,
         cu = (J.CompilationUnit) new ChangeMethodName(
                 "org.springframework.util.concurrent.ListenableFuture addCallback(..)", "whenComplete", true, true)
                 .getVisitor().visit(cu, ctx, getCursor().getParent());
-        cu = (J.CompilationUnit) new ChangeType(
+        return (J.CompilationUnit) new ChangeType(
                 "org.springframework.util.concurrent.ListenableFuture",
                 "java.util.concurrent.CompletableFuture", null)
                 .getVisitor().visit(cu, ctx, getCursor().getParent());
-        return cu;
     }
 }