[BUG] Compilation error: PHP Fatal error: Interceptor may not inherit from final class (Opengento\Gdpr\Block\Adminhtml\Customer\Edit\EraseButton)

[rizhk]

Description

A clear and concise description of what the bug is.

Prerequisites

PHP Version:

• 7.2.0

Magento Version:

• 2.3.6

Module Version:

• 3.0.0

Desktop (if applicable):

• OS: Linux(Ubuntu)

Issue Details

Steps to reproduce the behavior
bin/magento setup:di:compile will give error:

PHP Fatal error: Class Opengento\Gdpr\Block\Adminhtml\Customer\Edit\EraseButton\Interceptor may not inherit from final class (Opengento\Gdpr\Block\Adminhtml\Customer\Edit\EraseButton) in /var/www/html/generated/code/Opengento/Gdpr/Block/Adminhtml/Customer/Edit/EraseButton/Interceptor.php on line 7

Expected behavior
Compilation should not give any error

Screenshots

[thomas-kl1]

Hi @magentoguru

By curiosity, do you know what plugin is hooked to the ButtonProviderInterface?

[rizhk]

Thanks for your reply. i am afraid it is amasty module :(

[rizhk]

as amasty module have plugin hooking ButtonProviderInterface, just removing final keyword can fix this issue? thanks

[thomas-kl1]

Yes it will, I'm surprised they need to add plugin on this interface and not on a specific class. I'm curious what they are trying to achieve, I'll merge your MR asap

[rizhk]

Thanks so much :) just for your information, i just shared image to explain the usage of plugin, thanks again

[thomas-kl1]

That's sad they should have declared the plugin over concrete class :/ Thanks for sharing :)

[thomas-kl1]

@magentoguru Do you want to fix it on master also?

[rizhk]

Yes please do on the master as well thanks

[rizhk]

please let me know once it is merged to master, thanks so much :)