feat: make this app compatible with rsbuild #408
Conversation
The webpack configuration used to include a weird line, that allowed all non-implicit imports from src/. Such imports were ambiguous, and required modification of the resolve path, which is unconventional. To resolve this, we adopt the same solution as frontend-app-learning: src/ imports are written as `from '@src/...'`. To inform ESLint of this, we again draw inspiration from frontend-app-learning by loading the webpack config from tsconfig.json. This in turn triggers a new set of errors, which we fix in the next commit.
openedx-webhooks
added
the
open-source-contribution
|
Thanks for the pull request, @regisb! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
regisb
force-pushed
the
regisb/rsbuild
branch
3 times, most recently
from
920bd3a to
d4dccb9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #408 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 109 109
Lines 1085 1085
Branches 165 165
=========================================
Hits 1085 1085 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.