diff --git a/.eslintrc.js b/.eslintrc.js index 00ba97fc8..d7e76996d 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -6,9 +6,9 @@ const config = createConfig('eslint', { 'import/no-named-as-default-member': 'off', 'import/no-import-module-exports': 'off', 'import/no-self-import': 'off', - 'spaced-comment': ['error', 'always', { 'block': { 'exceptions': ['*'] } }], + 'spaced-comment': ['error', 'always', { block: { exceptions: ['*'] } }], 'react-hooks/rules-of-hooks': 'off', - "react/forbid-prop-types": ["error", { "forbid": ["any", "array"] }], // arguable object proptype is use when I do not care about the shape of the object + 'react/forbid-prop-types': ['error', { forbid: ['any', 'array'] }], // arguable object proptype is use when I do not care about the shape of the object 'no-import-assign': 'off', 'no-promise-executor-return': 'off', 'import/no-cycle': 'off', @@ -16,10 +16,10 @@ const config = createConfig('eslint', { }); config.settings = { - "import/resolver": { + 'import/resolver': { node: { - paths: ["src", "node_modules"], - extensions: [".js", ".jsx"], + paths: ['src', 'node_modules'], + extensions: ['.js', '.jsx'], }, }, }; diff --git a/src/components/InfoPopover/__snapshots__/index.test.jsx.snap b/src/components/InfoPopover/__snapshots__/index.test.jsx.snap index 086e04013..5e8f7357d 100644 --- a/src/components/InfoPopover/__snapshots__/index.test.jsx.snap +++ b/src/components/InfoPopover/__snapshots__/index.test.jsx.snap @@ -15,7 +15,7 @@ exports[`Info Popover Component snapshot 1`] = ` } - placement="right-end" + placement="left-end" trigger="focus" > ( diff --git a/src/containers/ListView/ListView.scss b/src/containers/ListView/ListView.scss index a51fcc7ed..6ea1bf608 100644 --- a/src/containers/ListView/ListView.scss +++ b/src/containers/ListView/ListView.scss @@ -25,4 +25,14 @@ span.pgn__icon.breadcrumb-arrow { margin-bottom: 0; } } + + @include media-breakpoint-down(xs) { + .badge { + white-space: normal; + } + + .pgn__table-actions > div:first-of-type { + z-index: $zindex-modal !important; + } + } } diff --git a/src/containers/ReviewActions/ReviewActions.scss b/src/containers/ReviewActions/ReviewActions.scss index 1fde9801e..52b48f428 100644 --- a/src/containers/ReviewActions/ReviewActions.scss +++ b/src/containers/ReviewActions/ReviewActions.scss @@ -34,4 +34,10 @@ .review-actions-username { padding-bottom: map-get($spacers, 3); } -} \ No newline at end of file +} + +@include media-breakpoint-down(xs) { + .overlay-help-popover { + max-width: calc(100% - 60px) !important; + } +} diff --git a/src/containers/ReviewActions/__snapshots__/index.test.jsx.snap b/src/containers/ReviewActions/__snapshots__/index.test.jsx.snap index a8a7bf71d..71f262ebb 100644 --- a/src/containers/ReviewActions/__snapshots__/index.test.jsx.snap +++ b/src/containers/ReviewActions/__snapshots__/index.test.jsx.snap @@ -18,7 +18,7 @@ exports[`ReviewActions component component snapshot: do not show rubric 1`] = ` status="grading-status" />
)} - + {pointsPossible && ( @@ -9,10 +10,16 @@ exports[`ReviewModal component component snapshots closed 1`] = ` } className="review-modal" + closeLabel="Close" + footerNode={null} + hasCloseButton={true} + isFullscreenScroll={false} isOpen={false} modalBodyClassName="review-modal-body" onClose={[MockFunction hooks.onClose]} + size="fullscreen" title="test-ora-name" + variant="dark" > @@ -29,10 +37,16 @@ exports[`ReviewModal component component snapshots loading 1`] = ` } className="review-modal" + closeLabel="Close" + footerNode={null} + hasCloseButton={true} + isFullscreenScroll={false} isOpen={true} modalBodyClassName="review-modal-body" onClose={[MockFunction hooks.onClose]} + size="fullscreen" title="test-ora-name" + variant="dark" > @@ -59,10 +74,16 @@ exports[`ReviewModal component component snapshots success 1`] = ` } className="review-modal" + closeLabel="Close" + footerNode={null} + hasCloseButton={true} + isFullscreenScroll={false} isOpen={true} modalBodyClassName="review-modal-body" onClose={[MockFunction hooks.onClose]} + size="fullscreen" title="test-ora-name" + variant="dark" > { isOpen, closeConfirmModalProps, } = hooks.rendererHooks({ dispatch, intl }); + + const isMobile = useMediaQuery({ query: '(max-width: 767.98px)' }); + return ( {title} : title} isOpen={isOpen} beforeBodyNode={( <> diff --git a/src/containers/ReviewModal/index.test.jsx b/src/containers/ReviewModal/index.test.jsx index 168853f7f..940b7aa04 100644 --- a/src/containers/ReviewModal/index.test.jsx +++ b/src/containers/ReviewModal/index.test.jsx @@ -19,6 +19,11 @@ jest.mock('./hooks', () => ({ rendererHooks: jest.fn(), })); +jest.mock('@edx/paragon', () => ({ + ...jest.requireActual('@edx/paragon'), + useMediaQuery: jest.fn(), +})); + const dispatch = useDispatch(); describe('ReviewModal component', () => {