fixup! refactor: move explicitly shared settings into new common module

Author: wgu-taylor-payne

.coveragerc

@@ -25,6 +25,7 @@ omit =
     common/djangoapps/*/migrations/*
     openedx/core/djangoapps/*/migrations/*
     openedx/core/djangoapps/debug/*
+    openedx/envs/*
     openedx/features/*/migrations/*
 
 concurrency=multiprocessing

.coveragerc-local

@@ -24,6 +24,7 @@ omit =
     common/djangoapps/*/migrations/*
     openedx/core/djangoapps/*/migrations/*
     openedx/core/djangoapps/debug/*
+    openedx/envs/*
     openedx/features/*/migrations/*
 
 concurrency=multiprocessing

lms/envs/docs/README.rst

@@ -1,7 +1,7 @@
 LMS Configuration Settings
 ##########################
 
-The ``lms.envs`` module contains project-wide settings, defined in python modules
+The ``lms.envs`` module contains lms related settings, defined in python modules
 using the standard `Django Settings`_ mechanism, plus some Open edX
 particularities, which we describe below.
 

openedx/core/djangoapps/user_authn/views/tests/test_register.py

@@ -2962,7 +2962,7 @@ def test_username_invalid_ascii_validation_decision(self, username):
         )
     ])
     def test_password_empty_validation_decision(self):
-        # 2 is the default setting for minimum length found in lms/envs/common.py
+        # 2 is the default setting for minimum length found in openedx/envs/common.py
         # under AUTH_PASSWORD_VALIDATORS.MinimumLengthValidator
         msg = 'This password is too short. It must contain at least 4 characters.'
         self.assertValidationDecision(
@@ -2977,7 +2977,7 @@ def test_password_empty_validation_decision(self):
     ])
     def test_password_bad_min_length_validation_decision(self):
         password = 'p'
-        # 2 is the default setting for minimum length found in lms/envs/common.py
+        # 2 is the default setting for minimum length found in openedx/envs/common.py
         # under AUTH_PASSWORD_VALIDATORS.MinimumLengthValidator
         msg = 'This password is too short. It must contain at least 4 characters.'
         self.assertValidationDecision(
@@ -2987,7 +2987,7 @@ def test_password_bad_min_length_validation_decision(self):
 
     def test_password_bad_max_length_validation_decision(self):
         password = 'p' * DEFAULT_MAX_PASSWORD_LENGTH
-        # 75 is the default setting for maximum length found in lms/envs/common.py
+        # 75 is the default setting for maximum length found in openedx/envs/common.py
         # under AUTH_PASSWORD_VALIDATORS.MaximumLengthValidator
         msg = 'This password is too long. It must contain no more than 75 characters.'
         self.assertValidationDecision(

scripts/vulture/find-dead-code.sh

@@ -37,7 +37,7 @@ echo '' > "$OUTPUT_FILE"
 # exclude test code from analysis, as it isn't explicitly called by other
 # code. Additionally, application code that is only called by tests
 # should be considered dead
-EXCLUSIONS='/test,/acceptance,cms/envs,lms/envs,migrations/,signals.py'
+EXCLUSIONS='/test,/acceptance,cms/envs,lms/envs,openedx/envs,migrations/,signals.py'
 MIN_CONFIDENCE=90
 # paths to the code on which to run the analysis
 CODE_PATHS=('cms' 'common' 'lms' 'openedx')

setup.cfg

@@ -20,7 +20,7 @@ filterwarnings =
     ignore:'etree' is deprecated. Use 'xml.etree.ElementTree' instead.:DeprecationWarning:wiki
 
 junit_family = xunit2
-norecursedirs = .* *.egg build conf dist node_modules test_root cms/envs lms/envs
+norecursedirs = .* *.egg build conf dist node_modules test_root cms/envs lms/envs openedx/envs
 python_classes =
 python_files = tests.py test_*.py tests_*.py *_tests.py __init__.py