Merge pull request #154 from mprahl/cherry-pick-pipeline-empty-input

Cherry pick Kubernetes resource input parameterization and handling empty optional pipeline inputs

Author: openshift-merge-bot[bot]

.github/workflows/kfp-samples.yml

@@ -31,6 +31,35 @@ jobs:
       with:
         python-version: 3.9
 
+    - name: apt-get update
+      run: sudo apt-get update
+
+    - name: Install protobuf-compiler
+      run: sudo apt-get install protobuf-compiler -y
+
+    - name: Install setuptools
+      run: |
+        pip3 install setuptools
+        pip3 freeze
+
+    - name: Install Wheel
+      run: pip3 install wheel==0.42.0
+
+    - name: Install protobuf
+      run: pip3 install protobuf==4.25.3
+
+    - name: Generate API proto files
+      working-directory: ./api
+      run: make python
+
+    - name: Install kfp-pipeline-spec from source
+      run: |
+        python3 -m pip install api/v2alpha1/python
+
+    - name: Generate, Build, and Install Kubernetes API proto files & packages
+      working-directory: ./kubernetes_platform
+      run: make python && pip install python/dist/*.whl
+
     - name: Create KFP cluster
       uses: ./.github/actions/kfp-cluster
       with:
@@ -65,4 +94,3 @@ jobs:
       with:
         name: kfp-samples-tests-artifacts-k8s-${{ matrix.k8s_version }}
         path: /tmp/tmp*/*
-

backend/src/v2/compiler/argocompiler/argo.go

@@ -72,8 +72,12 @@ func Compile(jobArg *pipelinespec.PipelineJob, kubernetesSpecArg *pipelinespec.S
 	specParams := spec.GetRoot().GetInputDefinitions().GetParameters()
 	for name, param := range specParams {
 		_, ok := job.RuntimeConfig.ParameterValues[name]
-		if !ok && param.GetDefaultValue() != nil {
-			job.RuntimeConfig.ParameterValues[name] = param.GetDefaultValue()
+		if !ok {
+			if param.GetDefaultValue() != nil {
+				job.RuntimeConfig.ParameterValues[name] = param.GetDefaultValue()
+			} else if param.IsOptional {
+				job.RuntimeConfig.ParameterValues[name] = structpb.NewNullValue()
+			}
 		}
 	}