fix(ytypes): fix node cache condition for unmarshalGeneric

jayzhudev · jayzhudev · commit 212fcc8cc51a · 2023-05-09T09:15:22.000-06:00
diff --git a/ytypes/node_cache.go b/ytypes/node_cache.go
@@ -123,7 +123,8 @@ func (c *NodeCache) set(path *gpb.Path, val interface{}, opts ...SetNodeOpt) (se
 	}
 
 	// Set value in the config tree.
-	if (*schema).Parent != nil && (*schema).Parent.IsContainer() {
+	// Condition: the parent is a container or a list.
+	if (*schema).Parent.IsContainer() || (*schema).Parent.IsList() {
 		var encoding Encoding
 		var options []UnmarshalOpt
 		if hasSetNodePreferShadowPath(opts) {

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,8 @@ func (c NodeCache) set(path gpb.Path, val interface{}, opts ...SetNodeOpt) (se`
`123`	`123`	`}`
`124`	`124`
`125`	`125`	`// Set value in the config tree.`
`126`		`- if (schema).Parent != nil && (schema).Parent.IsContainer() {`
	`126`	`+ // Condition: the parent is a container or a list.`
	`127`	`+ if (schema).Parent.IsContainer() \|\| (schema).Parent.IsList() {`
`127`	`128`	`var encoding Encoding`
`128`	`129`	`var options []UnmarshalOpt`
`129`	`130`	`if hasSetNodePreferShadowPath(opts) {`