Skip to content

Commit f26239c

Browse files
committed
Enhance Logs and Metrics Filters Labels
- Updated InputLabel components in LogsFilter and MetricsFilters to include id attributes for improved accessibility. - Added label properties to Select components to ensure proper association with their corresponding labels. - Ensured consistent labeling across filter components for better user experience.
1 parent 4b8d7ca commit f26239c

File tree

2 files changed

+26
-8
lines changed

2 files changed

+26
-8
lines changed

plugins/openchoreo-observability/src/components/Metrics/MetricsFilters.tsx

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,12 @@ export const MetricsFilters = ({
5454

5555
<Grid item xs={12} md={3}>
5656
<FormControl fullWidth disabled={disabled}>
57-
<InputLabel>Environment</InputLabel>
57+
<InputLabel id="environment-label">Environment</InputLabel>
5858
<Select
5959
value={filters.environment?.uid || ''}
6060
onChange={handleEnvironmentChange}
61+
labelId="environment-label"
62+
label="Environment"
6163
>
6264
{environments.map((environment: Environment) => (
6365
<MenuItem key={environment.uid} value={environment.uid}>
@@ -70,8 +72,13 @@ export const MetricsFilters = ({
7072

7173
<Grid item xs={12} md={3}>
7274
<FormControl fullWidth disabled={disabled}>
73-
<InputLabel>Time Range</InputLabel>
74-
<Select value={filters.timeRange} onChange={handleTimeRangeChange}>
75+
<InputLabel id="time-range-label">Time Range</InputLabel>
76+
<Select
77+
value={filters.timeRange}
78+
onChange={handleTimeRangeChange}
79+
labelId="time-range-label"
80+
label="Time Range"
81+
>
7582
{TIME_RANGE_OPTIONS.map((option: TimeRangeOption) => (
7683
<MenuItem key={option.value} value={option.value}>
7784
{option.label}

plugins/openchoreo/src/components/RuntimeLogs/LogsFilter.tsx

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -67,11 +67,13 @@ export const LogsFilter: FC<LogsFilterProps> = ({
6767
<Grid container spacing={3}>
6868
<Grid item xs={12} md={3}>
6969
<FormControl fullWidth disabled={disabled}>
70-
<InputLabel>Log Levels</InputLabel>
70+
<InputLabel id="log-levels-label">Log Levels</InputLabel>
7171
<Select
7272
multiple
7373
value={filters.logLevel}
7474
onChange={handleLogLevelSelectChange}
75+
labelId="log-levels-label"
76+
label="Log Levels"
7577
renderValue={selected => (selected as string[]).join(', ')}
7678
>
7779
{LOG_LEVELS.map(level => (
@@ -86,11 +88,13 @@ export const LogsFilter: FC<LogsFilterProps> = ({
8688

8789
<Grid item xs={12} md={3}>
8890
<FormControl fullWidth disabled={disabled}>
89-
<InputLabel>Selected Fields</InputLabel>
91+
<InputLabel id="selected-fields-label">Selected Fields</InputLabel>
9092
<Select
9193
multiple
9294
value={filters.selectedFields}
9395
onChange={handleSelectedFieldsChange}
96+
labelId="selected-fields-label"
97+
label="Selected Fields"
9498
renderValue={selected => (selected as LogEntryField[]).join(', ')}
9599
>
96100
{SELECTED_FIELDS.map((field: LogEntryField) => (
@@ -112,13 +116,15 @@ export const LogsFilter: FC<LogsFilterProps> = ({
112116

113117
<Grid item xs={12} md={3}>
114118
<FormControl fullWidth disabled={disabled || environmentsLoading}>
115-
<InputLabel>Environment</InputLabel>
119+
<InputLabel id="environment-label">Environment</InputLabel>
116120
{environmentsLoading ? (
117121
<Skeleton variant="rect" height={56} />
118122
) : (
119123
<Select
120124
value={filters.environmentId}
121125
onChange={handleEnvironmentChange}
126+
labelId="environment-label"
127+
label="Environment"
122128
>
123129
{environments.map(env => (
124130
<MenuItem key={env.id} value={env.id}>
@@ -132,8 +138,13 @@ export const LogsFilter: FC<LogsFilterProps> = ({
132138

133139
<Grid item xs={12} md={3}>
134140
<FormControl fullWidth disabled={disabled}>
135-
<InputLabel>Time Range</InputLabel>
136-
<Select value={filters.timeRange} onChange={handleTimeRangeChange}>
141+
<InputLabel id="time-range-label">Time Range</InputLabel>
142+
<Select
143+
value={filters.timeRange}
144+
onChange={handleTimeRangeChange}
145+
labelId="time-range-label"
146+
label="Time Range"
147+
>
137148
{TIME_RANGE_OPTIONS.map(option => (
138149
<MenuItem key={option.value} value={option.value}>
139150
{option.label}

0 commit comments

Comments
 (0)