[Redfish/event/SNMP] test "Configure SNMP Manager On BMC With Out Of Range Port And Verify" and "Configure SNMP Manager On BMC With Empty Port And Verify"

[Julia-Delta]

I have a question about out-of-range port and empty port.
The code designed that if port number was bigger than 65536, this port number will set the default value, like SNMP default port 162.

In the test case "Configure SNMP Manager On BMC With Out Of Range Port And Verify", a step is "Configure SNMP Manager Via Redfish ${SNMP_MGR1_IP} ${out_of_range_port} ${HTTP_BAD_REQUEST}" ask the return code be 400.
Actually I got the return code 201 because that the port number became 162, so I always test failed.

And in the test case "Configure SNMP Manager On BMC With Empty Port And Verify", the step is "Configure SNMP Manager Via Redfish ${SNMP_MGR1_IP} ${empty_port}", ask the return code be 201.
But I got the return code 400, not 201.

I though these two test case are simulier, why ask the different return code?
How should I to modify this issue?

[gkeishin]

@prkatti1 @meghagn5 Please check and respond

[mdmillerii]

I have a question about out-of-range port and empty port. The code designed that if port number was bigger than 65536, this port number will set the default value, like SNMP default port 162.

Are you asking which is correct the code or the testcase?

Are you trying to state a design choice by the coder has been implemented and are requesting the testcase pass?

I don't believe this choice is allowed by Redfish.

Specifically fi a valid non standard port was specified previously it is not allowed to mutate on receiving a patch request with an invalid or out of range value.

My reasoning

Redfish states that while many schema elements can be ignored if not implemented those that are implemented and mutable can only result in the specufied value being patched or the property be left unmodified.

However if multiple values are being changed it's permitted to apply some, a partial application is allowed with a 2xx level return (or the whole request can be rejected with an error).

Only if no change was applied because all portions were errors (be they read only, explicitly ignored like Odats.ID, invalid json object type, or value) is an error required to be returned.

This is described in the redfish service under the description of patch semantics.

Related observations of our codebase not part of to this issue

Our redfish service currently is not in compliance it incorrectly responds with an error after applying partial results in some places. It will require investment to enable mandated behavior.

A quality implementation will add an object with possibly multiple errors to the response for each rejected change. Our service never generates these and our web ui doesn't look for them.