Refactored LazyColumn implementation

Author: HekmatullahAmin

feature/about/src/androidMain/AndroidManifest.xml

@@ -10,8 +10,4 @@
 -->
 <manifest xmlns:android="http://schemas.android.com/apk/res/android">
 
-    <!--    <application-->
-    <!--        android:name=".AndroidApp">-->
-    <!--    </application>-->
-
 </manifest>

feature/about/src/androidMain/kotlin/org/mifos/mobile/feature/about/AndroidApp.kt

@@ -27,9 +27,9 @@ import mifos_mobile.feature.about.generated.resources.feature_about_description
 import mifos_mobile.feature.about.generated.resources.mifos_logo
 import org.jetbrains.compose.resources.painterResource
 import org.jetbrains.compose.resources.stringResource
-import org.mifos.mobile.core.ui.utils.DevicePreviews
+import org.mifos.mobile.core.ui.utils.DevicePreview
 
-@DevicePreviews
+@DevicePreview
 @Composable
 internal fun AboutUsHeader(
     modifier: Modifier = Modifier,

feature/about/src/commonMain/kotlin/org/mifos/mobile/feature/about/ui/AboutUsHeader.kt

@@ -16,6 +16,7 @@ import androidx.compose.foundation.layout.padding
 import androidx.compose.foundation.lazy.LazyColumn
 import androidx.compose.foundation.lazy.items
 import androidx.compose.runtime.Composable
+import androidx.compose.runtime.remember
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.unit.dp
 import mifos_mobile.feature.about.generated.resources.Res
@@ -35,15 +36,16 @@ import org.mifos.mobile.core.designsystem.theme.MifosMobileTheme
 import org.mifos.mobile.core.model.enums.AboutUsListItemId
 import org.mifos.mobile.core.ui.component.AboutUsItemCard
 import org.mifos.mobile.core.ui.component.MifosItemCard
-import org.mifos.mobile.core.ui.utils.DevicePreviews
+import org.mifos.mobile.core.ui.utils.DevicePreview
 import org.mifos.mobile.feature.about.AboutUsItem
 
 @Composable
 internal fun AboutUsScreen(
     navigateToItem: (AboutUsItem) -> Unit,
     modifier: Modifier = Modifier,
 ) {
-    val currentYear = DateHelper.currentDate.year
+    val currentYear = remember { DateHelper.currentDate.year }
+    val aboutUsItems = remember { getAboutUsItems() }
 
     LazyColumn(
         modifier = modifier
@@ -55,7 +57,7 @@ internal fun AboutUsScreen(
             AboutUsHeader()
         }
 
-        items(getAboutUsItem()) { item ->
+        items(items = aboutUsItems, key = { item -> item.itemId }) { item ->
             MifosItemCard(
                 modifier = Modifier.padding(bottom = 8.dp),
                 onClick = { navigateToItem(item) },
@@ -74,7 +76,7 @@ internal fun AboutUsScreen(
     }
 }
 
-private fun getAboutUsItem(): List<AboutUsItem> {
+private fun getAboutUsItems(): List<AboutUsItem> {
     return listOf(
         AboutUsItem(
             title = Res.string.feature_about_app_version,
@@ -108,7 +110,7 @@ private fun getAboutUsItem(): List<AboutUsItem> {
     )
 }
 
-@DevicePreviews
+@DevicePreview
 @Composable
 fun AboutScreenPreview() {
     MifosMobileTheme {

feature/about/src/commonMain/kotlin/org/mifos/mobile/feature/about/ui/AboutUsScreen.kt

@@ -56,7 +56,7 @@ private fun WebView(
     onLoadingChange: (isLoading: Boolean) -> Unit,
     modifier: Modifier = Modifier,
 ) {
-    Column(modifier) {
+    Column(modifier = modifier) {
         Spacer(modifier = Modifier.height(20.dp))
         MifosWebView(
             htmlContent = url,

feature/about/src/commonMain/kotlin/org/mifos/mobile/feature/about/ui/PrivacyPolicyScreen.kt

@@ -279,7 +279,7 @@ private fun RegistrationScreenContent(
                 PasswordStrengthState.STRONG,
                 PasswordStrengthState.GOOD,
                 PasswordStrengthState.VERY_STRONG,
-                    -> 1f
+                -> 1f
             }
             LinearProgressIndicator(
                 progress = { progress },

feature/auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/registration/RegistrationScreen.kt

@@ -57,25 +57,25 @@ include(":core:qrcode")
 //include(":core:testing")
 
 // Feature Modules
-//include(":feature:loan")
-//include(":feature:beneficiary")
-//include(":feature:savings")
-//include(":feature:guarantor")
-//include(":feature:qr")
-//include(":feature:transfer-process")
-//include(":feature:account")
-//include(":feature:recent-transaction")
-//include(":feature:client-charge")
-//include(":feature:third-party-transfer")
-//include(":feature:help")
-//include(":feature:notification")
-//include(":feature:location")
+include(":feature:loan")
+include(":feature:beneficiary")
+include(":feature:savings")
+include(":feature:guarantor")
+include(":feature:qr")
+include(":feature:transfer-process")
+include(":feature:account")
+include(":feature:recent-transaction")
+include(":feature:client-charge")
+include(":feature:third-party-transfer")
+include(":feature:help")
+include(":feature:notification")
+include(":feature:location")
 include(":feature:about")
-//include(":feature:settings")
-//include(":feature:auth")
-//include(":feature:update-password")
-//include(":feature:home")
-//include(":feature:user-profile")
+include(":feature:settings")
+include(":feature:auth")
+include(":feature:update-password")
+include(":feature:home")
+include(":feature:user-profile")
 
 // Lint Modules
 //include(":lint")