refactor: used enum for status

Author: Nagarjuna0033

feature/auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/otpAuthentication/OtpAuthenticationNavigation.kt

@@ -16,6 +16,7 @@ import androidx.navigation.NavGraphBuilder
 import androidx.navigation.NavOptions
 import kotlinx.serialization.Serializable
 import org.mifos.mobile.core.ui.composableWithStayTransitions
+import org.mifos.mobile.feature.auth.status.EventType
 
 @Serializable
 data object OtpAuthenticationRoute
@@ -25,7 +26,7 @@ fun NavController.navigateToOtpAuthScreen(navOptions: NavOptions? = null) {
 }
 
 fun NavGraphBuilder.otpAuthenticationDestination(
-    navigateToStatusScreen: (String, String) -> Unit,
+    navigateToStatusScreen: (EventType, String) -> Unit,
 ) {
     composableWithStayTransitions<OtpAuthenticationRoute> {
         OtpAuthenticationScreen(

feature/auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/otpAuthentication/OtpAuthenticationScreen.kt

@@ -34,6 +34,8 @@ import androidx.compose.ui.Modifier
 import androidx.compose.ui.text.input.KeyboardType
 import androidx.compose.ui.unit.dp
 import androidx.lifecycle.compose.collectAsStateWithLifecycle
+import kotlinx.serialization.SerialName
+import kotlinx.serialization.Serializable
 import mifos_mobile.feature.auth.generated.resources.Res
 import mifos_mobile.feature.auth.generated.resources.feature_common_cancel
 import mifos_mobile.feature.auth.generated.resources.feature_common_next
@@ -44,6 +46,7 @@ import mifos_mobile.feature.auth.generated.resources.feature_otp_subtitle
 import mifos_mobile.feature.auth.generated.resources.feature_otp_tip
 import mifos_mobile.feature.auth.generated.resources.feature_otp_title
 import org.jetbrains.compose.resources.stringResource
+import org.jetbrains.compose.ui.tooling.preview.Preview
 import org.koin.compose.viewmodel.koinViewModel
 import org.mifos.mobile.core.designsystem.component.BasicDialogState
 import org.mifos.mobile.core.designsystem.component.LoadingDialogState
@@ -56,13 +59,14 @@ import org.mifos.mobile.core.designsystem.component.MifosScaffold
 import org.mifos.mobile.core.designsystem.component.MifosTextFieldConfig
 import org.mifos.mobile.core.designsystem.icon.MifosIcons
 import org.mifos.mobile.core.designsystem.theme.DesignToken
+import org.mifos.mobile.core.designsystem.theme.MifosMobileTheme
 import org.mifos.mobile.core.designsystem.theme.MifosTypography
 import org.mifos.mobile.core.ui.component.MifosPoweredCard
 import org.mifos.mobile.core.ui.utils.EventsEffect
 
 @Composable
 internal fun OtpAuthenticationScreen(
-    navigateToStatusScreen: (String, String) -> Unit,
+    navigateToStatusScreen: (EventType, String) -> Unit,
     modifier: Modifier = Modifier,
     viewModel: OtpAuthenticationViewModel = koinViewModel(),
 ) {
@@ -277,3 +281,27 @@ internal fun OtpInputForm(
         }
     }
 }
+
+@Serializable
+enum class EventType {
+    @SerialName("success")
+    SUCCESS,
+
+    @SerialName("failure")
+    FAILURE,
+}
+
+@Preview
+@Composable
+internal fun Otp_Auth_Preview() {
+    MifosMobileTheme {
+        Column(
+            modifier = Modifier.padding(DesignToken.padding.large),
+        ) {
+            OptAuthScreenContent(
+                state = OtpAuthState(dialogState = null),
+                onAction = { },
+            )
+        }
+    }
+}

feature/auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/otpAuthentication/OtpAuthenticationViewModel.kt

@@ -14,11 +14,16 @@ import kotlinx.coroutines.Job
 import kotlinx.coroutines.delay
 import kotlinx.coroutines.flow.update
 import kotlinx.coroutines.launch
+import kotlinx.serialization.ExperimentalSerializationApi
+import kotlinx.serialization.InternalSerializationApi
+import kotlinx.serialization.serializer
 import mifos_mobile.feature.auth.generated.resources.Res
 import mifos_mobile.feature.auth.generated.resources.feature_otp_invalid_error
 import mifos_mobile.feature.auth.generated.resources.feature_otp_required_error
 import org.jetbrains.compose.resources.StringResource
 import org.mifos.mobile.core.ui.utils.BaseViewModel
+import org.mifos.mobile.feature.auth.login.LoginRoute
+import org.mifos.mobile.feature.auth.status.EventType
 
 internal class OtpAuthenticationViewModel : BaseViewModel<OtpAuthState, OtpAuthEvent, OtpAuthAction>(
     initialState = OtpAuthState(dialogState = null),
@@ -60,8 +65,8 @@ internal class OtpAuthenticationViewModel : BaseViewModel<OtpAuthState, OtpAuthE
 
     private fun validateOtp(otp: String): StringResource? {
         return when {
-            !otp.isNotBlank() -> Res.string.feature_otp_required_error
-            otp.length > 5 -> Res.string.feature_otp_invalid_error
+            otp.isBlank() -> Res.string.feature_otp_required_error
+            otp.length != 6 -> Res.string.feature_otp_invalid_error
             else -> null
         }
     }
@@ -79,6 +84,7 @@ internal class OtpAuthenticationViewModel : BaseViewModel<OtpAuthState, OtpAuthE
         }
     }
 
+    @OptIn(InternalSerializationApi::class, ExperimentalSerializationApi::class)
     private fun registerUser() {
         viewModelScope.launch {
             mutableStateFlow.update {
@@ -90,8 +96,8 @@ internal class OtpAuthenticationViewModel : BaseViewModel<OtpAuthState, OtpAuthE
             dismissDialog()
             sendEvent(
                 OtpAuthEvent.NavigateToStatus(
-                    "success",
-                    "login",
+                    EventType.SUCCESS,
+                    LoginRoute::class.serializer().descriptor.serialName,
                 ),
             )
         }
@@ -147,7 +153,7 @@ internal sealed interface OtpAuthAction {
 
 internal sealed interface OtpAuthEvent {
     data class NavigateToStatus(
-        val eventType: String,
+        val eventType: EventType,
         val eventDestination: String,
     ) : OtpAuthEvent
 }

feature/auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/status/Components.kt

@@ -24,10 +24,11 @@ import org.mifos.mobile.core.designsystem.component.MifosScaffold
 import org.mifos.mobile.core.designsystem.theme.DesignToken
 import org.mifos.mobile.core.ui.component.MifosPoweredCard
 import org.mifos.mobile.core.ui.component.MifosStatusComponent
+import org.mifos.mobile.feature.auth.otpAuthentication.EventType
 
 @Composable
 internal fun StatusScreen(
-    eventType: String,
+    eventType: EventType,
     eventDestination: String,
     buttonText: String,
     title: String,
@@ -51,7 +52,11 @@ internal fun StatusScreen(
             verticalArrangement = Arrangement.Center,
         ) {
             MifosStatusComponent(
-                icon = if (eventType == "success") Res.drawable.ic_icon_success else Res.drawable.ic_icon_error,
+                icon = if (eventType == EventType.SUCCESS) {
+                    Res.drawable.ic_icon_success
+                } else {
+                    Res.drawable.ic_icon_error
+                },
                 title = title,
                 subTitle = subtitle,
                 buttonText = buttonText,

feature/auth/src/commonMain/kotlin/org/mifos/mobile/feature/auth/status/StatusNavigation.kt

@@ -20,15 +20,15 @@ import org.mifos.mobile.feature.auth.otpAuthentication.OtpAuthenticationRoute
 
 @Serializable
 data class StatusNavigationRoute(
-    val eventType: String,
+    val eventType: EventType,
     val eventDestination: String,
     val buttonText: String = "Continue",
     val title: String = "Success",
     val subtitle: String = "You have completed the action.",
 )
 
 fun NavController.navigateToStatusScreen(
-    eventType: String,
+    eventType: EventType,
     eventDestination: String,
     buttonText: String = "Continue",
     title: String = "Success",