refactor(loan): show consistent loan actions for all account statuses

Author: Nagarjuna0033

core/model/src/commonMain/kotlin/org/mifos/mobile/core/model/LoanStatus.kt

@@ -24,5 +24,10 @@ enum class LoanStatus(val status: String) {
 
     REJECTED("Rejected"),
 
-    WITHDRAWN("Withdrawn by applicant"),
+    WITHDRAWN("Withdrawn by applicant");
+
+    companion object {
+        fun fromStatus(value: String?): LoanStatus? =
+            entries.firstOrNull { it.status.equals(value, ignoreCase = true) }
+    }
 }

core/model/src/commonMain/kotlin/org/mifos/mobile/core/model/entity/accounts/loan/Status.kt

@@ -10,6 +10,7 @@
 package org.mifos.mobile.core.model.entity.accounts.loan
 
 import kotlinx.serialization.Serializable
+import org.mifos.mobile.core.model.LoanStatus
 import org.mifos.mobile.core.model.Parcelable
 import org.mifos.mobile.core.model.Parcelize
 
@@ -40,6 +41,9 @@ data class Status(
 
 ) : Parcelable {
 
+    val loanStatus: LoanStatus?
+        get() = LoanStatus.fromStatus(value)
+
     fun isLoanTypeWithdrawn(): Boolean {
         return !(
             this.active == true || this.closed == true || this.pendingApproval == true ||

feature/loan-account/src/commonMain/kotlin/org/mifos/mobile/feature/loanaccount/loanAccountDetails/LoanAccountDetailsScreen.kt

@@ -30,6 +30,7 @@ import androidx.compose.ui.unit.dp
 import androidx.lifecycle.compose.collectAsStateWithLifecycle
 import kotlinx.collections.immutable.ImmutableList
 import mifos_mobile.feature.loan_account.generated.resources.Res
+import mifos_mobile.feature.loan_account.generated.resources.feature_account_action_make_payment
 import mifos_mobile.feature.loan_account.generated.resources.feature_account_details_action
 import mifos_mobile.feature.loan_account.generated.resources.feature_account_details_top_bar_title
 import mifos_mobile.feature.loan_account.generated.resources.feature_loan_next_installment_label
@@ -45,6 +46,7 @@ import org.mifos.mobile.core.designsystem.theme.AppColors
 import org.mifos.mobile.core.designsystem.theme.DesignToken
 import org.mifos.mobile.core.designsystem.theme.MifosMobileTheme
 import org.mifos.mobile.core.designsystem.theme.MifosTypography
+import org.mifos.mobile.core.model.LoanStatus
 import org.mifos.mobile.core.model.entity.AccountDetails
 import org.mifos.mobile.core.model.entity.TransferSuccessDestination
 import org.mifos.mobile.core.model.enums.ChargeType
@@ -163,8 +165,9 @@ internal fun LoanAccountDetailsContent(
                     )
                 }
 
-                if (state.isActive) {
+                if (state.shouldShowAction) {
                     SavingsAccountActions(
+                        canMakeTransfer = state.canMakeTransfer,
                         items = state.items,
                         onActionClick = {
                             onAction(LoanAccountDetailsAction.OnNavigateToAction(it))
@@ -222,6 +225,7 @@ internal fun AccountDetailsGrid(
 
 @Composable
 internal fun SavingsAccountActions(
+    canMakeTransfer: Boolean,
     items: ImmutableList<LoanActionItems>,
 //    onAction: (LoanAccountDetailsAction) -> Unit,
     onActionClick: (String) -> Unit,
@@ -237,14 +241,16 @@ internal fun SavingsAccountActions(
         FlowRow(
             modifier = Modifier.fillMaxWidth(),
         ) {
-            items.forEach { item ->
+            items
+                .filter { item ->
+                    !(item.title == Res.string.feature_account_action_make_payment && !canMakeTransfer)
+                }
+                .forEach { item ->
                 MifosActionCard(
                     title = item.title,
                     subTitle = item.subTitle,
                     icon = item.icon,
-                    onClick = {
-                        onActionClick(item.route)
-                    },
+                    onClick = { onActionClick(item.route) },
                 )
             }
         }

feature/loan-account/src/commonMain/kotlin/org/mifos/mobile/feature/loanaccount/loanAccountDetails/LoanAccountDetailsViewModel.kt

@@ -178,7 +178,7 @@ internal class LoanAccountDetailsViewModel(
         mutableStateFlow.update {
             it.copy(
                 accountId = loan?.id?.toLong() ?: -1L,
-                isActive = loan?.status?.value == LoanStatus.ACTIVE.status,
+                accountStatus = loan?.status?.loanStatus,
                 accountNumber = loan?.accountNo,
                 clientName = loan?.clientName,
                 product = loan?.loanProductName,
@@ -198,7 +198,7 @@ internal class LoanAccountDetailsViewModel(
  * @property accountId Unique ID for the loan account.
  * @property displayItems List of account metadata to be displayed.
  * @property transactionList List of most recent transaction details.
- * @property isActive True if the loan is active.
+ * @property accountStatus True if the loan is active.
  * @property items List of quick action items (e.g., Repay, Foreclose).
  * @property isUpdatable Whether the loan is editable (e.g., in a pending state).
  * @property dialogState State representing UI dialogs like loading or error.
@@ -214,7 +214,7 @@ internal data class LoanAccountDetailsState(
     val product: String? = "",
     val displayItems: List<LabelValueItem> = emptyList(),
     val transactionList: List<LabelValueItem>? = emptyList(),
-    val isActive: Boolean = false,
+    val accountStatus: LoanStatus? = LoanStatus.ACTIVE,
     val items: ImmutableList<LoanActionItems>,
     val isUpdatable: Boolean = false,
     val dialogState: DialogState?,
@@ -229,6 +229,15 @@ internal data class LoanAccountDetailsState(
         /** Shown during loading state. */
         data object Loading : DialogState
     }
+
+    val shouldShowAction: Boolean
+        get() = accountStatus !in setOf(
+            LoanStatus.SUBMIT_AND_PENDING_APPROVAL,
+            LoanStatus.REJECTED
+        )
+
+    val canMakeTransfer: Boolean
+        get() = accountStatus in setOf(LoanStatus.ACTIVE, LoanStatus.DISBURSED)
 }
 
 /**