Skip to content

Commit a9b3ca9

Browse files
committed
feat(home) Aligned Beneficiary and FAQ properly.
1 parent 8ba97ae commit a9b3ca9

File tree

2 files changed

+38
-26
lines changed

2 files changed

+38
-26
lines changed

feature/home/src/commonMain/kotlin/org/mifos/mobile/feature/home/HomeScreen.kt

Lines changed: 36 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -223,50 +223,60 @@ internal fun HomeContent(
223223
}
224224
}
225225
}
226+
226227
@Composable
227228
internal fun ServiceBox(
228229
items: ImmutableList<ServiceItem>,
229230
onAction: (HomeAction) -> Unit,
230231
modifier: Modifier = Modifier,
231232
) {
232-
FlowRow(
233-
modifier = modifier
234-
.fillMaxWidth(),
235-
maxItemsInEachRow = 4,
236-
horizontalArrangement = Arrangement.spacedBy(DesignToken.spacing.medium),
237-
verticalArrangement = Arrangement.spacedBy(DesignToken.spacing.medium),
233+
Column(
234+
modifier = modifier.fillMaxWidth(),
238235
) {
239-
items.forEach { item ->
240-
Box(
241-
modifier = Modifier
242-
.weight(1f),
243-
contentAlignment = Alignment.Center,
244-
) {
245-
ServiceItemCard(
246-
title = item.title,
247-
icon = item.icon,
248-
onClick = { onAction(HomeAction.OnNavigate(item.route)) },
249-
)
250-
}
236+
FlowRow(
237+
modifier = Modifier.fillMaxWidth(),
238+
horizontalArrangement = Arrangement.spacedBy(DesignToken.spacing.medium),
239+
verticalArrangement = Arrangement.spacedBy(DesignToken.spacing.large),
240+
maxItemsInEachRow = 4,
241+
) {
242+
items
243+
.filter { it != ServiceItem.Beneficiary && it != ServiceItem.Faq }
244+
.forEach { item ->
245+
ServiceItemCard(
246+
title = item.title,
247+
icon = item.icon,
248+
onClick = { onAction(HomeAction.OnNavigate(item.route)) },
249+
modifier = Modifier
250+
.width(72.dp)
251+
.wrapContentHeight(),
252+
)
253+
}
251254
}
252255

256+
Spacer(modifier = Modifier.height(DesignToken.spacing.large))
257+
253258
Row(
254259
modifier = Modifier
255-
.padding(DesignToken.padding.medium)
256-
.fillMaxWidth(2f),
257-
horizontalArrangement = Arrangement.spacedBy(DesignToken.spacing.medium),
258-
verticalAlignment = Alignment.CenterVertically
259-
){
260+
.fillMaxWidth(),
261+
horizontalArrangement = Arrangement.spacedBy(
262+
DesignToken.spacing.medium,
263+
Alignment.Start,
264+
),
265+
verticalAlignment = Alignment.CenterVertically,
266+
) {
260267
ServiceItemCard(
261268
title = ServiceItem.Beneficiary.title,
262269
icon = ServiceItem.Beneficiary.icon,
263-
onClick = { onAction(HomeAction.OnNavigate(ServiceItem.Beneficiary.route)) }
270+
onClick = { onAction(HomeAction.OnNavigate(ServiceItem.Beneficiary.route)) },
271+
modifier = Modifier
272+
.width(72.dp),
264273
)
265-
Spacer(modifier = Modifier.width(DesignToken.spacing.medium))
274+
266275
ServiceItemCard(
267276
title = ServiceItem.Faq.title,
268277
icon = ServiceItem.Faq.icon,
269-
onClick = { onAction(HomeAction.OnNavigate(ServiceItem.Faq.route)) }
278+
onClick = { onAction(HomeAction.OnNavigate(ServiceItem.Faq.route)) },
279+
modifier = Modifier.width(72.dp),
270280
)
271281
}
272282
}

feature/home/src/commonMain/kotlin/org/mifos/mobile/feature/home/ServiceItem.kt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,4 +102,6 @@ internal val serviceCards: ImmutableList<ServiceItem> = persistentListOf(
102102
ServiceItem.ApplyForShare,
103103
ServiceItem.TransactionHistory,
104104
ServiceItem.Charges,
105+
ServiceItem.Beneficiary,
106+
ServiceItem.Faq,
105107
)

0 commit comments

Comments
 (0)