fix : transaction_screen empty ui update (#2894)

Author: revanthkumarJ

feature/accounts/src/commonMain/composeResources/values/strings.xml

@@ -63,4 +63,5 @@
     <string name="feature_transaction_type">Transaction Type</string>
     <string name="feature_duration">Duration</string>
     <string name="feature_no_transactions_found">No Transactions Found</string>
+    <string name="feature_no__filtered_transactions_found">No Transactions Found for selected Filters</string>
 </resources>

feature/accounts/src/commonMain/kotlin/org/mifos/mobile/feature/accounts/accountTransactions/TransactionScreen.kt

@@ -39,6 +39,7 @@ import androidx.compose.ui.unit.dp
 import androidx.lifecycle.compose.collectAsStateWithLifecycle
 import mifos_mobile.feature.accounts.generated.resources.Res
 import mifos_mobile.feature.accounts.generated.resources.feature_duration
+import mifos_mobile.feature.accounts.generated.resources.feature_no__filtered_transactions_found
 import mifos_mobile.feature.accounts.generated.resources.feature_no_transactions_found
 import mifos_mobile.feature.accounts.generated.resources.feature_transaction_filter
 import mifos_mobile.feature.accounts.generated.resources.feature_transaction_filter_icon_description
@@ -125,28 +126,33 @@ internal fun TransactionScreenContent(
             }
         },
     ) {
-        LazyColumn(
-            Modifier.padding(DesignToken.padding.large),
+        if (state.isEmpty) {
+            EmptyDataView(
+                error = Res.string.feature_no_transactions_found,
+                icon = MifosIcons.Info,
+                modifier = Modifier.fillMaxSize(),
+            )
+        }
+
+        if (state.isFilteredRecordsEmpty && !state.isEmpty) {
+            EmptyDataView(
+                error = Res.string.feature_no__filtered_transactions_found,
+                icon = MifosIcons.Info,
+                modifier = Modifier.fillMaxSize(),
+            )
+        }
+
+        Column(
+            Modifier
+                .fillMaxSize()
+                .padding(DesignToken.padding.large),
         ) {
             if (!state.isEmpty && state.dialogState != AccountTransactionState.DialogState.Loading) {
-                item {
-                    ActionBar(
-                        onAction = onAction,
-                    )
-                }
-            }
-
-            if (state.isEmpty) {
-                item {
-                    EmptyDataView(
-                        error = Res.string.feature_no_transactions_found,
-                        icon = MifosIcons.Info,
-                        modifier = Modifier.fillMaxSize(),
-                    )
-                }
+                ActionBar(
+                    onAction = onAction,
+                )
             }
-
-            if (!state.isEmpty) {
+            LazyColumn {
                 state.filteredData.forEach { (date, transactions) ->
                     item {
                         Text(

feature/accounts/src/commonMain/kotlin/org/mifos/mobile/feature/accounts/accountTransactions/TransactionViewModel.kt

@@ -142,7 +142,7 @@ internal class AccountsTransactionViewModel(
                 selectedFilters = selectedFilters,
                 filteredData = filteredRecords,
                 isRefreshing = false,
-                isEmpty = filteredRecords.isEmpty(),
+                isFilteredRecordsEmpty = filteredRecords.isEmpty(),
             )
         }
         handleDismissDialog()
@@ -254,7 +254,8 @@ internal class AccountsTransactionViewModel(
                                 dialogState = null,
                                 data = transactions,
                                 filteredData = groupedTransactions,
-                                isEmpty = groupedTransactions.isEmpty(),
+                                isEmpty = transactions.isEmpty(),
+                                isFilteredRecordsEmpty = groupedTransactions.isEmpty(),
                             )
                         }
                     }
@@ -298,7 +299,8 @@ internal class AccountsTransactionViewModel(
                                 dialogState = null,
                                 data = transactions,
                                 filteredData = grouped,
-                                isEmpty = grouped.isEmpty(),
+                                isFilteredRecordsEmpty = grouped.isEmpty(),
+                                isEmpty = transactions.isEmpty(),
                             )
                         }
                     }
@@ -450,6 +452,7 @@ internal data class AccountTransactionState(
     val accountDurationFiltersCount: Int? = 0,
     val selectedRadioButton: StringResource? = null,
     val isEmpty: Boolean = false,
+    val isFilteredRecordsEmpty: Boolean = false,
 ) {
     /**
      * Sealed interface representing the different states of the dialog.