[instrumentation-redis and ioredis] multi/pipeline spans are not marked as such

[seth-shi]

What happened?

const pipe =redis.multi()
pipe.get
pipe.get
pipe.exec()

show two get. not exec

[pichlermarc]

Transferred to contrib since this seems to be about the redis instrumentation.
Details on this ticket are.. sparse, though.

[seth-shi]

ok, wait me a second, i will show the detail

[seth-shi]

click here expand the code

code

import { NodeSDK } from '@opentelemetry/sdk-node';
import { ConsoleSpanExporter, SimpleSpanProcessor } from '@opentelemetry/sdk-trace-node';
import { getNodeAutoInstrumentations } from '@opentelemetry/auto-instrumentations-node';



async function main() {
    const sdk = new NodeSDK({
        spanProcessors: [new SimpleSpanProcessor(new ConsoleSpanExporter())],
        instrumentations: [
            getNodeAutoInstrumentations({
                '@opentelemetry/instrumentation-ioredis': { enabled: true },
                '@opentelemetry/instrumentation-redis': { enabled: true },
            }),
        ],
    });
    await sdk.start();

    const { default: IORedis } = await import('ioredis');
    const { createClient } = await import('redis');

    // --- ioredis ---
    const redis1 = new IORedis({ host: '127.0.0.1', port: 6379 });
    await redis1.set('key1', 'value-from-ioredis');

    // pipeline with ioredis
    const pipe1 = redis1.pipeline();
    pipe1.get('key1');
    pipe1.set('key2', 'v2');
    pipe1.get('key2');
    const res1 = await pipe1.exec();
    console.log('ioredis pipeline result:', res1);

    // --- node-redis ---
    const redis2 = createClient({ url: 'redis://127.0.0.1:6379' });
    await redis2.connect();
    await redis2.set('keyA', 'value-from-node-redis');

    // pipeline with node-redis
    const pipe2 = redis2.multi();
    pipe2.get('keyA');
    pipe2.set('keyB', 'vB');
    pipe2.get('keyB');
    const res2 = await pipe2.exec();
    console.log('node-redis pipeline result:', res2);

    await new Promise((r) => setTimeout(r, 500));

    await redis1.quit();
    await redis2.quit();
    await sdk.shutdown();
}

main().catch((err) => {
    console.error('❌ Error in demo:', err);
})

this is output

ioredis pipeline result: [ [ null, 'value-from-ioredis' ], [ null, 'OK' ], [ null, 'v2' ] ]
{
  resource: {
    attributes: {
      'host.name': 'pc-beijing',
      'host.arch': 'amd64',
      'host.id': '1b4ff6be-7d02-49b4-8a07-34deae5e2105',
      'process.pid': 1812,
      'process.executable.name': '命令提示符 - node  src\\index.ts',
      'process.executable.path': 'C:\\Program Files\\nodejs\\node.exe',
      'process.command_args': [
        'C:\\Program Files\\nodejs\\node.exe',
        'D:\\__DEV\\untitled\\src\\index.ts'
      ],
      'process.runtime.version': '22.19.0',
      'process.runtime.name': 'nodejs',
      'process.runtime.description': 'Node.js',
      'process.command': 'D:\\__DEV\\untitled\\src\\index.ts',
      'process.owner': '10334',
      'service.name': 'unknown_service:node',
      'telemetry.sdk.language': 'nodejs',
      'telemetry.sdk.name': 'opentelemetry',
      'telemetry.sdk.version': '2.1.0'
    }
  },
  instrumentationScope: {
    name: '@opentelemetry/instrumentation-net',
    version: '0.49.0',
    schemaUrl: undefined
  },
  traceId: 'eaaa8212f7bc3b5a3a2b984ebbe254ec',
  parentSpanContext: undefined,
  traceState: undefined,
  name: 'tcp.connect',
  id: '53fb70b1b075edec',
  kind: 0,
  timestamp: 1758545162607000,
  duration: 4506.7,
  attributes: {
    'net.transport': 'ip_tcp',
    'net.peer.name': '127.0.0.1',
    'net.peer.port': 6379,
    'net.peer.ip': '',
    'net.host.ip': '127.0.0.1',
    'net.host.port': 5768
  },
  status: { code: 0 },
  events: [],
  links: []
}
{
  resource: {
    attributes: {
      'host.name': 'pc-beijing',
      'host.arch': 'amd64',
      'host.id': '1b4ff6be-7d02-49b4-8a07-34deae5e2105',
      'process.pid': 1812,
      'process.executable.name': '命令提示符 - node  src\\index.ts',
      'process.executable.path': 'C:\\Program Files\\nodejs\\node.exe',
      'process.command_args': [
        'C:\\Program Files\\nodejs\\node.exe',
        'D:\\__DEV\\untitled\\src\\index.ts'
      ],
      'process.runtime.version': '22.19.0',
      'process.runtime.name': 'nodejs',
      'process.runtime.description': 'Node.js',
      'process.command': 'D:\\__DEV\\untitled\\src\\index.ts',
      'process.owner': '10334',
      'service.name': 'unknown_service:node',
      'telemetry.sdk.language': 'nodejs',
      'telemetry.sdk.name': 'opentelemetry',
      'telemetry.sdk.version': '2.1.0'
    }
  },
  instrumentationScope: {
    name: '@opentelemetry/instrumentation-net',
    version: '0.49.0',
    schemaUrl: undefined
  },
  traceId: '69d53a0488623e441e5e61ff57d63383',
  parentSpanContext: {
    traceId: '69d53a0488623e441e5e61ff57d63383',
    spanId: 'a814e253c3b3c7a0',
    traceFlags: 1,
    traceState: undefined
  },
  traceState: undefined,
  name: 'tcp.connect',
  id: 'adc129c8819960f7',
  kind: 0,
  timestamp: 1758545162640000,
  duration: 9101.6,
  attributes: {
    'net.transport': 'ip_tcp',
    'net.peer.name': '127.0.0.1',
    'net.peer.port': 6379,
    'net.peer.ip': '127.0.0.1',
    'net.host.ip': '127.0.0.1',
    'net.host.port': 5769
  },
  status: { code: 0 },
  events: [],
  links: []
}
{
  resource: {
    attributes: {
      'host.name': 'pc-beijing',
      'host.arch': 'amd64',
      'host.id': '1b4ff6be-7d02-49b4-8a07-34deae5e2105',
      'process.pid': 1812,
      'process.executable.name': '命令提示符 - node  src\\index.ts',
      'process.executable.path': 'C:\\Program Files\\nodejs\\node.exe',
      'process.command_args': [
        'C:\\Program Files\\nodejs\\node.exe',
        'D:\\__DEV\\untitled\\src\\index.ts'
      ],
      'process.runtime.version': '22.19.0',
      'process.runtime.name': 'nodejs',
      'process.runtime.description': 'Node.js',
      'process.command': 'D:\\__DEV\\untitled\\src\\index.ts',
      'process.owner': '10334',
      'service.name': 'unknown_service:node',
      'telemetry.sdk.language': 'nodejs',
      'telemetry.sdk.name': 'opentelemetry',
      'telemetry.sdk.version': '2.1.0'
    }
  },
  instrumentationScope: {
    name: '@opentelemetry/instrumentation-redis',
    version: '0.54.1',
    schemaUrl: undefined
  },
  traceId: '69d53a0488623e441e5e61ff57d63383',
  parentSpanContext: undefined,
  traceState: undefined,
  name: 'redis-connect',
  id: 'a814e253c3b3c7a0',
  kind: 2,
  timestamp: 1758545162639000,
  duration: 13063.3,
  attributes: {
    'db.system': 'redis',
    'net.peer.name': '127.0.0.1',
    'net.peer.port': 6379,
    'db.connection_string': 'redis://127.0.0.1:6379'
  },
  status: { code: 0 },
  events: [],
  links: []
}
{
  resource: {
    attributes: {
      'host.name': 'pc-beijing',
      'host.arch': 'amd64',
      'host.id': '1b4ff6be-7d02-49b4-8a07-34deae5e2105',
      'process.pid': 1812,
      'process.executable.name': '命令提示符 - node  src\\index.ts',
      'process.executable.path': 'C:\\Program Files\\nodejs\\node.exe',
      'process.command_args': [
        'C:\\Program Files\\nodejs\\node.exe',
        'D:\\__DEV\\untitled\\src\\index.ts'
      ],
      'process.runtime.version': '22.19.0',
      'process.runtime.name': 'nodejs',
      'process.runtime.description': 'Node.js',
      'process.command': 'D:\\__DEV\\untitled\\src\\index.ts',
      'process.owner': '10334',
      'service.name': 'unknown_service:node',
      'telemetry.sdk.language': 'nodejs',
      'telemetry.sdk.name': 'opentelemetry',
      'telemetry.sdk.version': '2.1.0'
    }
  },
  instrumentationScope: {
    name: '@opentelemetry/instrumentation-redis',
    version: '0.54.1',
    schemaUrl: undefined
  },
  traceId: 'ab3da9969f462dd5ee5b0db4196166d0',
  parentSpanContext: undefined,
  traceState: undefined,
  name: 'redis-SET',
  id: 'bec5a725de9707c3',
  kind: 2,
  timestamp: 1758545162653000,
  duration: 731.7,
  attributes: {
    'db.system': 'redis',
    'net.peer.name': '127.0.0.1',
    'net.peer.port': 6379,
    'db.connection_string': 'redis://127.0.0.1:6379',
    'db.statement': 'SET keyA [1 other arguments]'
  },
  status: { code: 0 },
  events: [],
  links: []
}
{
  resource: {
    attributes: {
      'host.name': 'pc-beijing',
      'host.arch': 'amd64',
      'host.id': '1b4ff6be-7d02-49b4-8a07-34deae5e2105',
      'process.pid': 1812,
      'process.executable.name': '命令提示符 - node  src\\index.ts',
      'process.executable.path': 'C:\\Program Files\\nodejs\\node.exe',
      'process.command_args': [
        'C:\\Program Files\\nodejs\\node.exe',
        'D:\\__DEV\\untitled\\src\\index.ts'
      ],
      'process.runtime.version': '22.19.0',
      'process.runtime.name': 'nodejs',
      'process.runtime.description': 'Node.js',
      'process.command': 'D:\\__DEV\\untitled\\src\\index.ts',
      'process.owner': '10334',
      'service.name': 'unknown_service:node',
      'telemetry.sdk.language': 'nodejs',
      'telemetry.sdk.name': 'opentelemetry',
      'telemetry.sdk.version': '2.1.0'
    }
  },
  instrumentationScope: {
    name: '@opentelemetry/instrumentation-redis',
    version: '0.54.1',
    schemaUrl: undefined
  },
  traceId: 'b07fd687b7ecf230f21cdfebc7724905',
  parentSpanContext: undefined,
  traceState: undefined,
  name: 'redis-GET',
  id: 'ec6fae361fd811d5',
  kind: 2,
  timestamp: 1758545162655000,
  duration: 1608,
  attributes: {
    'db.system': 'redis',
    'net.peer.name': '127.0.0.1',
    'net.peer.port': 6379,
    'db.connection_string': 'redis://127.0.0.1:6379',
    'db.statement': 'GET keyA'
  },
  status: { code: 0 },
  events: [],
  links: []
}
{
  resource: {
    attributes: {
      'host.name': 'pc-beijing',
      'host.arch': 'amd64',
      'host.id': '1b4ff6be-7d02-49b4-8a07-34deae5e2105',
      'process.pid': 1812,
      'process.executable.name': '命令提示符 - node  src\\index.ts',
      'process.executable.path': 'C:\\Program Files\\nodejs\\node.exe',
      'process.command_args': [
        'C:\\Program Files\\nodejs\\node.exe',
        'D:\\__DEV\\untitled\\src\\index.ts'
      ],
      'process.runtime.version': '22.19.0',
      'process.runtime.name': 'nodejs',
      'process.runtime.description': 'Node.js',
      'process.command': 'D:\\__DEV\\untitled\\src\\index.ts',
      'process.owner': '10334',
      'service.name': 'unknown_service:node',
      'telemetry.sdk.language': 'nodejs',
      'telemetry.sdk.name': 'opentelemetry',
      'telemetry.sdk.version': '2.1.0'
    }
  },
  instrumentationScope: {
    name: '@opentelemetry/instrumentation-redis',
    version: '0.54.1',
    schemaUrl: undefined
  },
  traceId: 'ceca330d6baf6c7a0b5fd55cc0fbfb40',
  parentSpanContext: undefined,
  traceState: undefined,
  name: 'redis-SET',
  id: 'd07b21ca982c731e',
  kind: 2,
  timestamp: 1758545162655000,
  duration: 1773.5,
  attributes: {
    'db.system': 'redis',
    'net.peer.name': '127.0.0.1',
    'net.peer.port': 6379,
    'db.connection_string': 'redis://127.0.0.1:6379',
    'db.statement': 'SET keyB [1 other arguments]'
  },
  status: { code: 0 },
  events: [],
  links: []
}
{
  resource: {
    attributes: {
      'host.name': 'pc-beijing',
      'host.arch': 'amd64',
      'host.id': '1b4ff6be-7d02-49b4-8a07-34deae5e2105',
      'process.pid': 1812,
      'process.executable.name': '命令提示符 - node  src\\index.ts',
      'process.executable.path': 'C:\\Program Files\\nodejs\\node.exe',
      'process.command_args': [
        'C:\\Program Files\\nodejs\\node.exe',
        'D:\\__DEV\\untitled\\src\\index.ts'
      ],
      'process.runtime.version': '22.19.0',
      'process.runtime.name': 'nodejs',
      'process.runtime.description': 'Node.js',
      'process.command': 'D:\\__DEV\\untitled\\src\\index.ts',
      'process.owner': '10334',
      'service.name': 'unknown_service:node',
      'telemetry.sdk.language': 'nodejs',
      'telemetry.sdk.name': 'opentelemetry',
      'telemetry.sdk.version': '2.1.0'
    }
  },
  instrumentationScope: {
    name: '@opentelemetry/instrumentation-redis',
    version: '0.54.1',
    schemaUrl: undefined
  },
  traceId: 'bc4fa9e33284eb8630e18f7c7d7f06fe',
  parentSpanContext: undefined,
  traceState: undefined,
  name: 'redis-GET',
  id: '007aa1974da7131a',
  kind: 2,
  timestamp: 1758545162655000,
  duration: 1994.5,
  attributes: {
    'db.system': 'redis',
    'net.peer.name': '127.0.0.1',
    'net.peer.port': 6379,
    'db.connection_string': 'redis://127.0.0.1:6379',
    'db.statement': 'GET keyB'
  },
  status: { code: 0 },
  events: [],
  links: []
}
node-redis pipeline result: [ 'value-from-node-redis', 'OK', 'vB' ]

[pichlermarc]

@seth-shi so you're getting no spans when using ioredis, is that correct?

[seth-shi]

@seth-shi so you're getting no spans when using ioredis, is that correct?

loook my code. ioredis and node-redis don't have multi exec