refactor: extract runtimes #200
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loks0n
force-pushed
the
refactor-extract-runtimes
branch
from
7b6847f to
49a38f7
Compare
loks0n
force-pushed
the
refactor-extract-runtimes
branch
from
49a38f7 to
0c84250
Compare
abnegate
approved these changes
Nov 24, 2025
Meldiron
reviewed
Nov 24, 2025
Comment on lines
+401
to
+403
| if ($this->runtimes->exists($runtimeName)) { | ||
| $existingRuntime = $this->runtimes->get($runtimeName); | ||
| if ($existingRuntime !== null && $existingRuntime->status === 'pending') { |
Contributor
There was a problem hiding this comment.
I think there is one extra operation here. exists and get() !== null is same result, I think
Meldiron
reviewed
Nov 24, 2025
Comment on lines
+422
to
+424
| 0, | ||
| $image, | ||
| 0, |
Contributor
There was a problem hiding this comment.
For those numbers, better code readability would be named params
Meldiron
reviewed
Nov 24, 2025
Comment on lines
+594
to
+600
| if ($runtime !== null) { | ||
| $runtime->updated = \microtime(true); | ||
| $runtime->status = 'Up ' . \round($duration, 2) . 's'; | ||
| $runtime->initialised = 1; | ||
|
|
||
| $this->runtimes->set($runtimeName, $runtime); | ||
| } |
Contributor
There was a problem hiding this comment.
get&set are not atomic, but I think swoole tables can be atomic. maybe some kind of update or setProperty. Let's chcek, could be nice improvement here
Meldiron
reviewed
Nov 24, 2025
Meldiron
reviewed
Nov 24, 2025
| return $createdNetworks; | ||
| } | ||
|
|
||
| public function getRuntimes(): mixed |
Contributor
There was a problem hiding this comment.
Do we need those getRuntimes and getRuntime methods anymore? If needed, could Runtimes become a registry item, or resource of request, to prevent need for those methods?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swoole\Tableusage into a dedicatedRuntimesrepository +Runtimedto.nikic/php-parser.Conceptually this is enables coroutines and paying down some technical debt: it localises the Swoole bits, makes Docker easier to reason about, and gives a single abstraction for “active runtimes”.