No docs without a properly installed sphinx (with modules). #19
Conversation
The logic to install the dpc was missing a protection around the case where sphinx was installed but the modules required for OMPI were not. I slightly change the order of operations to ensure that we never try to install the docs if there were not available (aka not from a tarball) or not properly generated. Signed-off-by: George Bosilca <[email protected]>
bosilca
force-pushed
the
topic/fix_doc_generation
branch
from
9615285 to
9101740
Compare
|
Do you want to merge this and then update the relevant OMPI submodules ( |
|
How do we update the submodule consistently across all projects (ompi, prrte and openpmix) ? |
We don't. We just have to update the submodule pointer everywhere, which means a bunch of individual PRs. However, this is still far better than having N copies of this m4 code all over the place. Consolidating the OAC definitely fixed that problem and really helped avoid all the m4 code drift that was really causing issues across the different projects. |
|
I'll take care of PRRTE and PMIx once this gets committed. |
|
I can't merge, I guess I don't have write access. |
Merged! |
|
PMIx and PRRTE have been updated! |
3 participants
The logic to install the dpc was missing a protection around the case where sphinx was installed but the modules required for OMPI were not. I slightly change the order of operations to ensure that we never try to install the docs if there were not available (aka not from a tarball) or not properly generated.