WIP: Support rescorings of type finding/falco

Author: 8R0WNI3

src/findings.js

@@ -20,6 +20,7 @@ import { artefactMetadataFilter } from './ocm/util'
 export const FINDING_TYPES = {
   CRYPTO: 'finding/crypto',
   DIKI: 'finding/diki',
+  FALCO: 'finding/falco',
   LICENSE: 'finding/license',
   MALWARE: 'finding/malware',
   OSID: 'finding/osid',

src/ocm/model.js

@@ -166,6 +166,10 @@ export const dataKey = ({type, data}) => {
   if (type === FINDING_TYPES.DIKI) return asKey({
     props: [data.provider_id, data.ruleset_id, data.rule_id]
   })
+
+  if (type === FINDING_TYPES.FALCO) return asKey({
+    props: [data.finding.group_hash],
+  })
 }
 
 

src/rescoring.js

@@ -1233,6 +1233,38 @@ DikiExtraInfo.propTypes = {
 }
 
 
+const FalcoExtraInfo = ({
+  finding,
+}) => {
+  return <ExtraWideTooltip
+    title={
+      <div style={{ overflowY: 'auto', maxHeight: '30rem' }}>
+        <Typography
+          variant='inherit'
+          sx={{
+            fontWeight: 'bold',
+          }}
+          marginBottom='0.5rem'
+        >
+          Properties
+        </Typography>
+        <Typography variant='inherit' whiteSpace='pre-wrap'>
+          {
+            JSON.stringify(finding, null, 2)
+          }
+        </Typography>
+      </div>
+    }
+  >
+    <InfoOutlinedIcon sx={{ height: '1rem' }}/>
+  </ExtraWideTooltip>
+}
+FalcoExtraInfo.displayName = 'FalcoExtraInfo'
+FalcoExtraInfo.propTypes = {
+  finding: PropTypes.object.isRequired,
+}
+
+
 const Subject = ({
   rescoring,
   ocmNode,
@@ -1310,6 +1342,31 @@ const Subject = ({
         </div>
       </div>
     </Stack>
+  } else if (rescoring.finding_type === FINDING_TYPES.FALCO) {
+    return <Stack>
+      <div style={{ display: 'flex', alignItems: 'center' }}>
+        <div>
+          <Typography variant='inherit'>
+            {
+              finding.finding.landscape
+            }
+          </Typography>
+          <Typography variant='inherit' marginRight='0.4rem'>
+            {
+              `Project: ${finding.finding.project}`
+            }
+          </Typography>
+          <Typography variant='inherit'>Clusters:</Typography>
+          {
+            finding.finding.clusters.map((cluster, idx) => <Typography key={idx} variant='inherit'>
+              {
+                `- ${cluster.name}`
+              }
+            </Typography>)
+          }
+        </div>
+      </div>
+    </Stack>
   }
 }
 Subject.displayName = 'Subject'
@@ -1581,6 +1638,15 @@ const Finding = ({
         </Typography>
       </div>
     </Stack>
+  } else if (rescoring.finding_type === FINDING_TYPES.FALCO) {
+    return <div style={{ display: 'flex' }}>
+      <Typography variant='inherit' marginRight='0.4rem'>
+        {
+          `Rule: ${finding.finding.rule}`
+        }
+      </Typography>
+      <FalcoExtraInfo finding={finding.finding}/>
+    </div>
   }
 }
 Finding.displayName = 'Finding'
@@ -2054,6 +2120,17 @@ const RescoringContent = ({
       }).value,
     }
 
+    const falcoAccess = {
+      [orderAttributes.SUBJECT]: rescoring.finding.finding?.landscape,
+      [orderAttributes.FINDING]: rescoring.finding.finding?.rule,
+      [orderAttributes.SPRINT]: rescoring.sprint ? new Date(rescoring.sprint.end_date) : new Date(8640000000000000),
+      [orderAttributes.CURRENT]: categoriseRescoringProposal({rescoring, findingCfg}).value,
+      [orderAttributes.RESCORED]: findCategorisationById({
+        id: rescoring.severity,
+        findingCfg: findingCfg,
+      }).value,
+    }
+
     if (
       rescoringType === FINDING_TYPES.VULNERABILITY
       || rescoringType === FINDING_TYPES.LICENSE
@@ -2067,6 +2144,8 @@ const RescoringContent = ({
       return cryptoAccess[desired]
     } else if (rescoringType === FINDING_TYPES.DIKI) {
       return dikiAccess[desired]
+    } else if (rescoringType === FINDING_TYPES.FALCO) {
+      return falcoAccess[desired]
     }
 
   }
@@ -2524,6 +2603,10 @@ const Rescore = ({
           ruleset_id: rescoring.finding.ruleset_id,
           rule_id: rescoring.finding.rule_id,
         }
+      } else if (type === FINDING_TYPES.FALCO) {
+        return {
+          group_hash: rescoring.finding.finding.group_hash,
+        }
       }
     }
 

src/util.js

@@ -199,9 +199,9 @@ export const filterRescoringsForFinding = (finding, rescorings) => {
         rescoring.data.finding.license.name !== finding.data.license.name
         || rescoring.data.finding.package_name !== finding.data.package_name
       ) return false
-    } else if (finding.meta.type === FINDING_TYPES.MALWARE) {
-      // `malware` has a little special handling here because its findings contain a
-      // sub-property `finding` whereas its rescoring does not contain this sub-property anymore
+    } else if ([FINDING_TYPES.MALWARE, FINDING_TYPES.FALCO].includes(finding.meta.type)) {
+      // `malware` and `falco` have a little special handling here because their findings contain a
+      // sub-property `finding` whereas their rescoring does not contain this sub-property anymore
       if (
         dataKey({type: finding.meta.type, data: rescoring.data})
         !== dataKey({type: finding.meta.type, data: finding.data})