Update rollout logic to use Progressing condition instead of WorkApplied (#1207)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Signed-off-by: Qing Hao <[email protected]>
Co-authored-by: Claude <[email protected]>

Author: haoqing0110

pkg/work/hub/controllers/manifestworkreplicasetcontroller/manifestworkreplicaset_deploy_reconcile.go

@@ -209,41 +209,54 @@ func (d *deployReconciler) reconcile(ctx context.Context, mwrSet *workapiv1alpha
 }
 
 func (d *deployReconciler) clusterRolloutStatusFunc(clusterName string, manifestWork workv1.ManifestWork) (clustersdkv1alpha1.ClusterRolloutStatus, error) {
+	// Initialize default status as ToApply, LastTransitionTime is not needed for ToApply status.
 	clsRolloutStatus := clustersdkv1alpha1.ClusterRolloutStatus{
-		ClusterName:        clusterName,
-		LastTransitionTime: &manifestWork.CreationTimestamp,
-		// Default status is ToApply
-		Status: clustersdkv1alpha1.ToApply,
+		ClusterName: clusterName,
+		Status:      clustersdkv1alpha1.ToApply,
 	}
 
-	appliedCondition := apimeta.FindStatusCondition(manifestWork.Status.Conditions, workv1.WorkApplied)
-
-	// Applied condition not exist return status as ToApply.
-	if appliedCondition == nil { //nolint:gocritic
-		return clsRolloutStatus, nil
-	} else if appliedCondition.Status == metav1.ConditionTrue ||
-		apimeta.IsStatusConditionTrue(manifestWork.Status.Conditions, workv1.WorkProgressing) {
-		// Applied OR Progressing conditions status true return status as Progressing
-		// ManifestWork Progressing status is not defined however the check is made for future work availability.
-		clsRolloutStatus.Status = clustersdkv1alpha1.Progressing
-	} else if appliedCondition.Status == metav1.ConditionFalse {
-		// Applied Condition status false return status as failed
-		clsRolloutStatus.Status = clustersdkv1alpha1.Failed
-		clsRolloutStatus.LastTransitionTime = &appliedCondition.LastTransitionTime
+	// Get all relevant conditions
+	progressingCond := apimeta.FindStatusCondition(manifestWork.Status.Conditions, workv1.WorkProgressing)
+	degradedCond := apimeta.FindStatusCondition(manifestWork.Status.Conditions, workv1.WorkDegraded)
+
+	// Return ToApply if:
+	// - No Progressing condition exists yet (work hasn't been reconciled by agent)
+	// - Progressing condition hasn't observed the latest spec
+	// - Degraded condition exists but hasn't observed the latest spec
+	//   (Degraded is optional, but if it exists, we wait for it to catch up)
+	if progressingCond == nil ||
+		progressingCond.ObservedGeneration != manifestWork.Generation ||
+		(degradedCond != nil && degradedCond.ObservedGeneration != manifestWork.Generation) {
 		return clsRolloutStatus, nil
 	}
 
-	// Available condition return status as Succeeded
-	if apimeta.IsStatusConditionTrue(manifestWork.Status.Conditions, workv1.WorkAvailable) {
+	// Agent has observed the latest spec, determine status based on Progressing and Degraded conditions.
+	// Degraded is an optional condition only used to determine Failed case.
+	// - Progressing=True + Degraded=True → Failed (work is progressing but degraded)
+	// - Progressing=True (not degraded) → Progressing
+	// - Progressing=False → Succeeded
+	// - Unknown state → Progressing (conservative fallback)
+	//
+	// LastTransitionTime is used by rollout strategies to calculate:
+	// - Timeout for Progressing and Failed statuses
+	// - Minimum success time (soak time) for Succeeded status
+	switch {
+	case progressingCond.Status == metav1.ConditionTrue && degradedCond != nil && degradedCond.Status == metav1.ConditionTrue:
+		clsRolloutStatus.Status = clustersdkv1alpha1.Failed
+		clsRolloutStatus.LastTransitionTime = &degradedCond.LastTransitionTime
+
+	case progressingCond.Status == metav1.ConditionTrue:
+		clsRolloutStatus.Status = clustersdkv1alpha1.Progressing
+		clsRolloutStatus.LastTransitionTime = &progressingCond.LastTransitionTime
+
+	case progressingCond.Status == metav1.ConditionFalse:
 		clsRolloutStatus.Status = clustersdkv1alpha1.Succeeded
-		return clsRolloutStatus, nil
-	}
+		clsRolloutStatus.LastTransitionTime = &progressingCond.LastTransitionTime
 
-	// Degraded condition return status as Failed
-	// ManifestWork Degraded status is not defined however the check is made for future work availability.
-	if apimeta.IsStatusConditionTrue(manifestWork.Status.Conditions, workv1.WorkDegraded) {
-		clsRolloutStatus.Status = clustersdkv1alpha1.Failed
-		clsRolloutStatus.LastTransitionTime = &appliedCondition.LastTransitionTime
+	default:
+		// Unknown state, conservatively treat as still progressing
+		clsRolloutStatus.Status = clustersdkv1alpha1.Progressing
+		clsRolloutStatus.LastTransitionTime = &progressingCond.LastTransitionTime
 	}
 
 	return clsRolloutStatus, nil