Skip to content

Conversation

@yue9944882
Copy link
Member

@openshift-ci openshift-ci bot requested review from mdelder and qiujian16 September 29, 2021 09:32
@openshift-ci
Copy link

openshift-ci bot commented Sep 29, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yue9944882
To complete the pull request process, please assign mdelder after the PR has been reviewed.
You can assign the PR to them by writing /assign @mdelder in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- Having a new resource `clustergateway` and its subresource `proxy` based on
apiserver aggregation.
- Adding a new optional component named `cluster-gateway` for delegating requests
to the spoke clusters.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this will support mTLS, should we add this in the non-goal?

resourceAttributes:
group: ""
resource: "namespaces"
verb: "foo/get"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, is the verb can also be virtual? so in this case, the user needs to have this rule on hub, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants