Skip to content

add Bolin number formulae #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

AgnieszkaZaba
Copy link
Collaborator

addresses #1662
(clean version of previous PR)

Copy link

codecov bot commented Jul 2, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.67%. Comparing base (156f86c) to head (fedd2db).

Files with missing lines Patch % Lines
...physics/isotope_relaxation_timescale/bolin_1958.py 66.66% 1 Missing ⚠️
...physics/isotope_relaxation_timescale/zaba_et_al.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1669      +/-   ##
==========================================
- Coverage   85.68%   85.67%   -0.02%     
==========================================
  Files         405      405              
  Lines        9790     9796       +6     
==========================================
+ Hits         8389     8393       +4     
- Misses       1401     1403       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


@staticmethod
def bolin_number(const):
return const.BOLIN_ISOTOPE_TIMESCALE_COEFF_C1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest moving to trivia as:

def tau(Bo, dm_dt_over_m):
   ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants