Skip to content

removing rnd reuse logic (disabled by default) #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

emmacware
Copy link
Collaborator

No description provided.

@slayoo
Copy link
Member

slayoo commented Jun 14, 2025

OK, in the 2D kinematic setup, the reuse logic is enabled by default:

self.coalescence_optimized_random = True

Copy link

codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.46%. Comparing base (20c8340) to head (94ce24c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1642      +/-   ##
==========================================
- Coverage   85.53%   85.46%   -0.08%     
==========================================
  Files         396      394       -2     
  Lines        9601     9541      -60     
==========================================
- Hits         8212     8154      -58     
+ Misses       1389     1387       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@slayoo
Copy link
Member

slayoo commented Jun 15, 2025

IIUC, with the reuse disabled, we are shuffling all n_sd numbers regardless of how many are actually needed in a given substep. So, I'd suggest that before removing the reuse logic, we implement a scheme to alter the amount of shuffled numbers depending on how many are actually needed in a given substep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants